[mail@asciiwolf.com: Re: ethtool: Incorrect component type in AppStream metainfo causes issues and possible breakages]

[mail@asciiwolf.com: Re: ethtool: Incorrect component type in AppStream metainfo causes issues and possible breakages]

[Michal Kubecek]

Hello,

I got this report (and one more where you are already in Cc) but I'm not
familiar with the AppStream stuff at all. Can you take a look, please?

Michal

> Date: Fri, 11 Apr 2025 15:16:28 +0200
> From: AsciiWolf <mail@asciiwolf.com>
> To: Michal Kubecek <mkubecek@suse.cz>
> Subject: Re: ethtool: Incorrect component type in AppStream metainfo causes
>  issues and possible breakages
> 
> This probably also needs to be fixed:
> 
> https://freedesktop.org/software/appstream/docs/
> sect-Metadata-ConsoleApplication.html#tag-consoleapp-provides
> 
> Regards,
> Daniel
> 
> pá 11. 4. 2025 v 15:06 odesílatel AsciiWolf <mail@asciiwolf.com> napsal:
> 
>     Hello Michal,
> 
>     ethtool is user uninstallable via GUI (such as GNOME Software or KDE
>     Discover) since 6.14. This is not correct since it is a (in many
>     configurations pre-installed) system tool, not user app, and uninstalling
>     it can also uninstall other critical system packages.
> 
>     The main problem is the "desktop" component type in AppStream metadata:
> 
>     $ head org.kernel.software.network.ethtool.metainfo.xml
>     <?xml version="1.0" encoding="UTF-8"?>
>     <component type="desktop">
>       <id>org.kernel.software.network.ethtool</id>
>       <metadata_license>MIT</metadata_license>
>       <name>ethtool</name>
>       <summary>display or change Ethernet device settings</summary>
>       <description>
>         <p>ethtool can be used to query and change settings such as speed,
>         auto- negotiation and checksum offload on many network devices,
>         especially Ethernet devices.</p>
> 
>     The correct component type should be "console-application".[1]
> 
>     Alternative solution would be removing the whole metainfo file.
> 
>     Please see our (Fedora) downstream ticket for more information:
>     https://bugzilla.redhat.com/show_bug.cgi?id=2359069
> 
>     Regards,
>     Daniel Rusek
> 
>     [1] https://freedesktop.org/software/appstream/docs/
>     sect-Metadata-ConsoleApplication.html or https://freedesktop.org/software/
>     appstream/docs/chap-Metadata.html#sect-Metadata-GenericComponent

Re: ethtool: Incorrect component type in AppStream metainfo causes issues and possible breakages

[Petter Reinholdtsen]

[AsciiWolf]
> Sure,
>
> I will take a look at this later today.

This is my cut-n-paste error.  The reporter is absolutely correct that
the component type should not be desktop as there is no .destop file
associated with the package.

The quick and actually working fix is to replace '<component
type="desktop">' with '<component>'.  A more correct entry would be to
use '<component type="console-application">', but at least on Debian
these two are equivalent.

I am terribly sorry for not noticing when I sent the original patch.

-- 
Happy hacking
Petter Reinholdtsen

Re: [mail@asciiwolf.com: Re: ethtool: Incorrect component type in AppStream metainfo causes issues and possible breakages]

[AsciiWolf]

[-- Attachment #1: Type: text/plain, Size: 3418 bytes --]

Here is the proposed fix. It is validated using appstreamcli validate
and should work without issues.

--- org.kernel.software.network.ethtool.metainfo.xml_orig
2025-03-31 00:46:03.000000000 +0200
+++ org.kernel.software.network.ethtool.metainfo.xml    2025-04-11
22:14:11.634355310 +0200
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<component type="desktop">
+<component type="console-application">
   <id>org.kernel.software.network.ethtool</id>
   <metadata_license>MIT</metadata_license>
   <name>ethtool</name>
@@ -11,6 +11,7 @@
   </description>
   <url type="homepage">https://www.kernel.org/pub/software/network/ethtool/</url>
   <provides>
+    <binary>ethtool</binary>
     <modalias>pci:v*d*sv*sd*bc02sc80i*</modalias>
   </provides>
 </component>

Regards,
Daniel Rusek


pá 11. 4. 2025 v 15:50 odesílatel AsciiWolf <mail@asciiwolf.com> napsal:
>
> Sure,
>
> I will take a look at this later today.
>
> Regards,
> Daniel
>
> Dne pá 11. 4. 2025 15:47 uživatel Michal Kubecek <mkubecek@suse.cz> napsal:
>>
>> Hello,
>>
>> I got this report (and one more where you are already in Cc) but I'm not
>> familiar with the AppStream stuff at all. Can you take a look, please?
>>
>> Michal
>>
>> > Date: Fri, 11 Apr 2025 15:16:28 +0200
>> > From: AsciiWolf <mail@asciiwolf.com>
>> > To: Michal Kubecek <mkubecek@suse.cz>
>> > Subject: Re: ethtool: Incorrect component type in AppStream metainfo causes
>> >  issues and possible breakages
>> >
>> > This probably also needs to be fixed:
>> >
>> > https://freedesktop.org/software/appstream/docs/
>> > sect-Metadata-ConsoleApplication.html#tag-consoleapp-provides
>> >
>> > Regards,
>> > Daniel
>> >
>> > pá 11. 4. 2025 v 15:06 odesílatel AsciiWolf <mail@asciiwolf.com> napsal:
>> >
>> >     Hello Michal,
>> >
>> >     ethtool is user uninstallable via GUI (such as GNOME Software or KDE
>> >     Discover) since 6.14. This is not correct since it is a (in many
>> >     configurations pre-installed) system tool, not user app, and uninstalling
>> >     it can also uninstall other critical system packages.
>> >
>> >     The main problem is the "desktop" component type in AppStream metadata:
>> >
>> >     $ head org.kernel.software.network.ethtool.metainfo.xml
>> >     <?xml version="1.0" encoding="UTF-8"?>
>> >     <component type="desktop">
>> >       <id>org.kernel.software.network.ethtool</id>
>> >       <metadata_license>MIT</metadata_license>
>> >       <name>ethtool</name>
>> >       <summary>display or change Ethernet device settings</summary>
>> >       <description>
>> >         <p>ethtool can be used to query and change settings such as speed,
>> >         auto- negotiation and checksum offload on many network devices,
>> >         especially Ethernet devices.</p>
>> >
>> >     The correct component type should be "console-application".[1]
>> >
>> >     Alternative solution would be removing the whole metainfo file.
>> >
>> >     Please see our (Fedora) downstream ticket for more information:
>> >     https://bugzilla.redhat.com/show_bug.cgi?id=2359069
>> >
>> >     Regards,
>> >     Daniel Rusek
>> >
>> >     [1] https://freedesktop.org/software/appstream/docs/
>> >     sect-Metadata-ConsoleApplication.html or https://freedesktop.org/software/
>> >     appstream/docs/chap-Metadata.html#sect-Metadata-GenericComponent

[-- Attachment #2: org.kernel.software.network.ethtool.metainfo.xml --]
[-- Type: text/xml, Size: 665 bytes --]

<?xml version="1.0" encoding="UTF-8"?>
<component type="console-application">
  <id>org.kernel.software.network.ethtool</id>
  <metadata_license>MIT</metadata_license>
  <name>ethtool</name>
  <summary>display or change Ethernet device settings</summary>
  <description>
    <p>ethtool can be used to query and change settings such as speed,
    auto- negotiation and checksum offload on many network devices,
    especially Ethernet devices.</p>
  </description>
  <url type="homepage">https://www.kernel.org/pub/software/network/ethtool/</url>
  <provides>
    <binary>ethtool</binary>
    <modalias>pci:v*d*sv*sd*bc02sc80i*</modalias>
  </provides>
</component>

Re: [mail@asciiwolf.com: Re: ethtool: Incorrect component type in AppStream metainfo causes issues and possible breakages]

[AsciiWolf]

Please note that as pointed out in my previous emails, the binary
provides seems to be required for console-application component type.

Daniel

pá 11. 4. 2025 v 22:18 odesílatel AsciiWolf <mail@asciiwolf.com> napsal:

>
> Here is the proposed fix. It is validated using appstreamcli validate
> and should work without issues.
>
> --- org.kernel.software.network.ethtool.metainfo.xml_orig
> 2025-03-31 00:46:03.000000000 +0200
> +++ org.kernel.software.network.ethtool.metainfo.xml    2025-04-11
> 22:14:11.634355310 +0200
> @@ -1,5 +1,5 @@
>  <?xml version="1.0" encoding="UTF-8"?>
> -<component type="desktop">
> +<component type="console-application">
>    <id>org.kernel.software.network.ethtool</id>
>    <metadata_license>MIT</metadata_license>
>    <name>ethtool</name>
> @@ -11,6 +11,7 @@
>    </description>
>    <url type="homepage">https://www.kernel.org/pub/software/network/ethtool/</url>
>    <provides>
> +    <binary>ethtool</binary>
>      <modalias>pci:v*d*sv*sd*bc02sc80i*</modalias>
>    </provides>
>  </component>
>
> Regards,
> Daniel Rusek
>
>
> pá 11. 4. 2025 v 15:50 odesílatel AsciiWolf <mail@asciiwolf.com> napsal:
> >
> > Sure,
> >
> > I will take a look at this later today.
> >
> > Regards,
> > Daniel
> >
> > Dne pá 11. 4. 2025 15:47 uživatel Michal Kubecek <mkubecek@suse.cz> napsal:
> >>
> >> Hello,
> >>
> >> I got this report (and one more where you are already in Cc) but I'm not
> >> familiar with the AppStream stuff at all. Can you take a look, please?
> >>
> >> Michal
> >>
> >> > Date: Fri, 11 Apr 2025 15:16:28 +0200
> >> > From: AsciiWolf <mail@asciiwolf.com>
> >> > To: Michal Kubecek <mkubecek@suse.cz>
> >> > Subject: Re: ethtool: Incorrect component type in AppStream metainfo causes
> >> >  issues and possible breakages
> >> >
> >> > This probably also needs to be fixed:
> >> >
> >> > https://freedesktop.org/software/appstream/docs/
> >> > sect-Metadata-ConsoleApplication.html#tag-consoleapp-provides
> >> >
> >> > Regards,
> >> > Daniel
> >> >
> >> > pá 11. 4. 2025 v 15:06 odesílatel AsciiWolf <mail@asciiwolf.com> napsal:
> >> >
> >> >     Hello Michal,
> >> >
> >> >     ethtool is user uninstallable via GUI (such as GNOME Software or KDE
> >> >     Discover) since 6.14. This is not correct since it is a (in many
> >> >     configurations pre-installed) system tool, not user app, and uninstalling
> >> >     it can also uninstall other critical system packages.
> >> >
> >> >     The main problem is the "desktop" component type in AppStream metadata:
> >> >
> >> >     $ head org.kernel.software.network.ethtool.metainfo.xml
> >> >     <?xml version="1.0" encoding="UTF-8"?>
> >> >     <component type="desktop">
> >> >       <id>org.kernel.software.network.ethtool</id>
> >> >       <metadata_license>MIT</metadata_license>
> >> >       <name>ethtool</name>
> >> >       <summary>display or change Ethernet device settings</summary>
> >> >       <description>
> >> >         <p>ethtool can be used to query and change settings such as speed,
> >> >         auto- negotiation and checksum offload on many network devices,
> >> >         especially Ethernet devices.</p>
> >> >
> >> >     The correct component type should be "console-application".[1]
> >> >
> >> >     Alternative solution would be removing the whole metainfo file.
> >> >
> >> >     Please see our (Fedora) downstream ticket for more information:
> >> >     https://bugzilla.redhat.com/show_bug.cgi?id=2359069
> >> >
> >> >     Regards,
> >> >     Daniel Rusek
> >> >
> >> >     [1] https://freedesktop.org/software/appstream/docs/
> >> >     sect-Metadata-ConsoleApplication.html or https://freedesktop.org/software/
> >> >     appstream/docs/chap-Metadata.html#sect-Metadata-GenericComponent

Re: [mail@asciiwolf.com: Re: ethtool: Incorrect component type in AppStream metainfo causes issues and possible breakages]

[Salvatore Bonaccorso]

Hi Michal,

On Fri, Apr 11, 2025 at 10:48:44PM +0200, AsciiWolf wrote:
> Please note that as pointed out in my previous emails, the binary
> provides seems to be required for console-application component type.
> 
> Daniel
> 
> pá 11. 4. 2025 v 22:18 odesílatel AsciiWolf <mail@asciiwolf.com> napsal:
> 
> >
> > Here is the proposed fix. It is validated using appstreamcli validate
> > and should work without issues.
> >
> > --- org.kernel.software.network.ethtool.metainfo.xml_orig
> > 2025-03-31 00:46:03.000000000 +0200
> > +++ org.kernel.software.network.ethtool.metainfo.xml    2025-04-11
> > 22:14:11.634355310 +0200
> > @@ -1,5 +1,5 @@
> >  <?xml version="1.0" encoding="UTF-8"?>
> > -<component type="desktop">
> > +<component type="console-application">
> >    <id>org.kernel.software.network.ethtool</id>
> >    <metadata_license>MIT</metadata_license>
> >    <name>ethtool</name>
> > @@ -11,6 +11,7 @@
> >    </description>
> >    <url type="homepage">https://www.kernel.org/pub/software/network/ethtool/</url>
> >    <provides>
> > +    <binary>ethtool</binary>
> >      <modalias>pci:v*d*sv*sd*bc02sc80i*</modalias>
> >    </provides>
> >  </component>
> >
> > Regards,
> > Daniel Rusek

Is there anything else you need from us here? Or are you waiting for
us for a git am'able patch? If Daniel Rusek prefers to not submit one,
I can re-iterate with the required changes my proposal 
https://lore.kernel.org/netdev/20250411141023.14356-2-carnil@debian.org/
with the needed changes.

We would like to apply the change in downstream Debian fwiw, but only
with the variant accepted by upstream.

Regards,
Salvatore

Re: [mail@asciiwolf.com: Re: ethtool: Incorrect component type in AppStream metainfo causes issues and possible breakages]

[Michal Kubecek]

[-- Attachment #1: Type: text/plain, Size: 1757 bytes --]

On Thu, Apr 24, 2025 at 03:29:15PM +0200, Salvatore Bonaccorso wrote:
> Hi Michal,
> 
> On Fri, Apr 11, 2025 at 10:48:44PM +0200, AsciiWolf wrote:
> > Please note that as pointed out in my previous emails, the binary
> > provides seems to be required for console-application component type.
> > 
> > Daniel
> > 
> > pá 11. 4. 2025 v 22:18 odesílatel AsciiWolf <mail@asciiwolf.com> napsal:
> > 
> > >
> > > Here is the proposed fix. It is validated using appstreamcli validate
> > > and should work without issues.
> > >
> > > --- org.kernel.software.network.ethtool.metainfo.xml_orig
> > > 2025-03-31 00:46:03.000000000 +0200
> > > +++ org.kernel.software.network.ethtool.metainfo.xml    2025-04-11
> > > 22:14:11.634355310 +0200
> > > @@ -1,5 +1,5 @@
> > >  <?xml version="1.0" encoding="UTF-8"?>
> > > -<component type="desktop">
> > > +<component type="console-application">
> > >    <id>org.kernel.software.network.ethtool</id>
> > >    <metadata_license>MIT</metadata_license>
> > >    <name>ethtool</name>
> > > @@ -11,6 +11,7 @@
> > >    </description>
> > >    <url type="homepage">https://www.kernel.org/pub/software/network/ethtool/</url>
> > >    <provides>
> > > +    <binary>ethtool</binary>
> > >      <modalias>pci:v*d*sv*sd*bc02sc80i*</modalias>
> > >    </provides>
> > >  </component>
> > >
> > > Regards,
> > > Daniel Rusek
> 
> Is there anything else you need from us here? Or are you waiting for
> us for a git am'able patch? If Daniel Rusek prefers to not submit one,
> I can re-iterate with the required changes my proposal 
> https://lore.kernel.org/netdev/20250411141023.14356-2-carnil@debian.org/
> with the needed changes.

Yes, please. I'll need a formally submitted patch.

Michal

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [mail@asciiwolf.com: Re: ethtool: Incorrect component type in AppStream metainfo causes issues and possible breakages]

[Salvatore Bonaccorso]

Hi Michal,

On Fri, Apr 25, 2025 at 06:46:31PM +0200, Michal Kubecek wrote:
> On Thu, Apr 24, 2025 at 03:29:15PM +0200, Salvatore Bonaccorso wrote:
> > Hi Michal,
> > 
> > On Fri, Apr 11, 2025 at 10:48:44PM +0200, AsciiWolf wrote:
> > > Please note that as pointed out in my previous emails, the binary
> > > provides seems to be required for console-application component type.
> > > 
> > > Daniel
> > > 
> > > pá 11. 4. 2025 v 22:18 odesílatel AsciiWolf <mail@asciiwolf.com> napsal:
> > > 
> > > >
> > > > Here is the proposed fix. It is validated using appstreamcli validate
> > > > and should work without issues.
> > > >
> > > > --- org.kernel.software.network.ethtool.metainfo.xml_orig
> > > > 2025-03-31 00:46:03.000000000 +0200
> > > > +++ org.kernel.software.network.ethtool.metainfo.xml    2025-04-11
> > > > 22:14:11.634355310 +0200
> > > > @@ -1,5 +1,5 @@
> > > >  <?xml version="1.0" encoding="UTF-8"?>
> > > > -<component type="desktop">
> > > > +<component type="console-application">
> > > >    <id>org.kernel.software.network.ethtool</id>
> > > >    <metadata_license>MIT</metadata_license>
> > > >    <name>ethtool</name>
> > > > @@ -11,6 +11,7 @@
> > > >    </description>
> > > >    <url type="homepage">https://www.kernel.org/pub/software/network/ethtool/</url>
> > > >    <provides>
> > > > +    <binary>ethtool</binary>
> > > >      <modalias>pci:v*d*sv*sd*bc02sc80i*</modalias>
> > > >    </provides>
> > > >  </component>
> > > >
> > > > Regards,
> > > > Daniel Rusek
> > 
> > Is there anything else you need from us here? Or are you waiting for
> > us for a git am'able patch? If Daniel Rusek prefers to not submit one,
> > I can re-iterate with the required changes my proposal 
> > https://lore.kernel.org/netdev/20250411141023.14356-2-carnil@debian.org/
> > with the needed changes.
> 
> Yes, please. I'll need a formally submitted patch.

Here is the respective patch to apply to the git three with the
credits hopefully all on the correct spot.

if you want something changed let me please know.

Regards,
Salvatore

From 7daa26e40d0888c13a2346053638408c03376015 Mon Sep 17 00:00:00 2001
From: Salvatore Bonaccorso <carnil@debian.org>
Date: Fri, 11 Apr 2025 15:58:55 +0200
Subject: [PATCH] Set type property to console-application for provided
 AppStream metainfo XML

As pointed out in the Debian downstream report, as ethtool is a
command-line tool the XML root myst have the type property set to
console-application.

Additionally with the type propety set to desktop, ethtool is user
uninstallable via GUI (such as GNOME Software or KDE Discover).

console-application AppStream metainfo XML at least one binary provided
must be listed in the <binary> tag, thus add the required value along.

Fixes: 02d505bba6fe ("Add AppStream metainfo XML with modalias documented supported hardware.")
Reported-by: Daniel Rusek <asciiwolf@seznam.cz>
Co-Developed-by: Daniel Rusek <asciiwolf@seznam.cz>
Link: https://bugs.debian.org/1102647
Link: https://bugzilla.redhat.com/show_bug.cgi?id=2359069
Link: https://freedesktop.org/software/appstream/docs/sect-Metadata-ConsoleApplication.html
Tested-by: Petter Reinholdtsen <pere@hungry.com>
Signed-off-by: Salvatore Bonaccorso <carnil@debian.org>
---
 org.kernel.software.network.ethtool.metainfo.xml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/org.kernel.software.network.ethtool.metainfo.xml b/org.kernel.software.network.ethtool.metainfo.xml
index efe84c17e4cd..7cfacf223af7 100644
--- a/org.kernel.software.network.ethtool.metainfo.xml
+++ b/org.kernel.software.network.ethtool.metainfo.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<component type="desktop">
+<component type="console-application">
   <id>org.kernel.software.network.ethtool</id>
   <metadata_license>MIT</metadata_license>
   <name>ethtool</name>
@@ -11,6 +11,7 @@
   </description>
   <url type="homepage">https://www.kernel.org/pub/software/network/ethtool/</url>
   <provides>
+    <binary>ethtool</binary>
     <modalias>pci:v*d*sv*sd*bc02sc80i*</modalias>
   </provides>
 </component>
-- 
2.49.0

Re: [mail@asciiwolf.com: Re: ethtool: Incorrect component type in AppStream metainfo causes issues and possible breakages]

[Michal Kubecek]

[-- Attachment #1: Type: text/plain, Size: 2292 bytes --]

On Fri, Apr 25, 2025 at 09:38:05PM +0200, Salvatore Bonaccorso wrote:
> From 7daa26e40d0888c13a2346053638408c03376015 Mon Sep 17 00:00:00 2001
> From: Salvatore Bonaccorso <carnil@debian.org>
> Date: Fri, 11 Apr 2025 15:58:55 +0200
> Subject: [PATCH] Set type property to console-application for provided
>  AppStream metainfo XML
> 
> As pointed out in the Debian downstream report, as ethtool is a
> command-line tool the XML root myst have the type property set to
> console-application.
> 
> Additionally with the type propety set to desktop, ethtool is user
> uninstallable via GUI (such as GNOME Software or KDE Discover).
> 
> console-application AppStream metainfo XML at least one binary provided
> must be listed in the <binary> tag, thus add the required value along.
> 
> Fixes: 02d505bba6fe ("Add AppStream metainfo XML with modalias documented supported hardware.")
> Reported-by: Daniel Rusek <asciiwolf@seznam.cz>
> Co-Developed-by: Daniel Rusek <asciiwolf@seznam.cz>
> Link: https://bugs.debian.org/1102647
> Link: https://bugzilla.redhat.com/show_bug.cgi?id=2359069
> Link: https://freedesktop.org/software/appstream/docs/sect-Metadata-ConsoleApplication.html
> Tested-by: Petter Reinholdtsen <pere@hungry.com>
> Signed-off-by: Salvatore Bonaccorso <carnil@debian.org>
> ---
>  org.kernel.software.network.ethtool.metainfo.xml | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/org.kernel.software.network.ethtool.metainfo.xml b/org.kernel.software.network.ethtool.metainfo.xml
> index efe84c17e4cd..7cfacf223af7 100644
> --- a/org.kernel.software.network.ethtool.metainfo.xml
> +++ b/org.kernel.software.network.ethtool.metainfo.xml
> @@ -1,5 +1,5 @@
>  <?xml version="1.0" encoding="UTF-8"?>
> -<component type="desktop">
> +<component type="console-application">
>    <id>org.kernel.software.network.ethtool</id>
>    <metadata_license>MIT</metadata_license>
>    <name>ethtool</name>
> @@ -11,6 +11,7 @@
>    </description>
>    <url type="homepage">https://www.kernel.org/pub/software/network/ethtool/</url>
>    <provides>
> +    <binary>ethtool</binary>
>      <modalias>pci:v*d*sv*sd*bc02sc80i*</modalias>
>    </provides>
>  </component>
> -- 
> 2.49.0

Applied now, thank you.

Michal

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [mail@asciiwolf.com: Re: ethtool: Incorrect component type in AppStream metainfo causes issues and possible breakages]

[Salvatore Bonaccorso]

Hi,

On Tue, Apr 29, 2025 at 10:37:36PM +0200, Michal Kubecek wrote:
> On Fri, Apr 25, 2025 at 09:38:05PM +0200, Salvatore Bonaccorso wrote:
> > From 7daa26e40d0888c13a2346053638408c03376015 Mon Sep 17 00:00:00 2001
> > From: Salvatore Bonaccorso <carnil@debian.org>
> > Date: Fri, 11 Apr 2025 15:58:55 +0200
> > Subject: [PATCH] Set type property to console-application for provided
> >  AppStream metainfo XML
> > 
> > As pointed out in the Debian downstream report, as ethtool is a
> > command-line tool the XML root myst have the type property set to
> > console-application.
> > 
> > Additionally with the type propety set to desktop, ethtool is user
> > uninstallable via GUI (such as GNOME Software or KDE Discover).
> > 
> > console-application AppStream metainfo XML at least one binary provided
> > must be listed in the <binary> tag, thus add the required value along.
> > 
> > Fixes: 02d505bba6fe ("Add AppStream metainfo XML with modalias documented supported hardware.")
> > Reported-by: Daniel Rusek <asciiwolf@seznam.cz>
> > Co-Developed-by: Daniel Rusek <asciiwolf@seznam.cz>
> > Link: https://bugs.debian.org/1102647
> > Link: https://bugzilla.redhat.com/show_bug.cgi?id=2359069
> > Link: https://freedesktop.org/software/appstream/docs/sect-Metadata-ConsoleApplication.html
> > Tested-by: Petter Reinholdtsen <pere@hungry.com>
> > Signed-off-by: Salvatore Bonaccorso <carnil@debian.org>
> > ---
> >  org.kernel.software.network.ethtool.metainfo.xml | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/org.kernel.software.network.ethtool.metainfo.xml b/org.kernel.software.network.ethtool.metainfo.xml
> > index efe84c17e4cd..7cfacf223af7 100644
> > --- a/org.kernel.software.network.ethtool.metainfo.xml
> > +++ b/org.kernel.software.network.ethtool.metainfo.xml
> > @@ -1,5 +1,5 @@
> >  <?xml version="1.0" encoding="UTF-8"?>
> > -<component type="desktop">
> > +<component type="console-application">
> >    <id>org.kernel.software.network.ethtool</id>
> >    <metadata_license>MIT</metadata_license>
> >    <name>ethtool</name>
> > @@ -11,6 +11,7 @@
> >    </description>
> >    <url type="homepage">https://www.kernel.org/pub/software/network/ethtool/</url>
> >    <provides>
> > +    <binary>ethtool</binary>
> >      <modalias>pci:v*d*sv*sd*bc02sc80i*</modalias>
> >    </provides>
> >  </component>
> > -- 
> > 2.49.0
> 
> Applied now, thank you.

Thank you much appreciated. I just noticed a glitch we have in our
metainfo file again, claiming the metadata license is MIT license, but
the rest of upstream files are GPL-2.

If all contributors to the file agree I would like to suggest we
switch consistently to GPL-2.0.

Regards,
Salvatore

Re: [mail@asciiwolf.com: Re: ethtool: Incorrect component type in AppStream metainfo causes issues and possible breakages]

[Salvatore Bonaccorso]

Hi,

On Wed, Apr 30, 2025 at 04:46:28PM +0200, AsciiWolf wrote:
> GPL is not a valid AppStream metadata license. See the official spec:
> https://freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-metadata_license

Yes, you are right, so nothing to change here.

Regards,
Salvatore