From: Herbert Xu <herbert@gondor.apana.org.au>
To: Sabrina Dubroca <sd@queasysnail.net>
Cc: netdev@vger.kernel.org, Steffen Klassert <steffen.klassert@secunet.com>
Subject: Re: [PATCH ipsec] xfrm: ipcomp: fix truesize computation on receive
Date: Sat, 26 Apr 2025 09:53:39 +0800 [thread overview]
Message-ID: <aAw8o89W6F9uLuDo@gondor.apana.org.au> (raw)
In-Reply-To: <f507d25958589ed4e6f62cdc4b8df64865865818.1745591479.git.sd@queasysnail.net>
On Fri, Apr 25, 2025 at 04:32:55PM +0200, Sabrina Dubroca wrote:
> ipcomp_post_acomp currently drops all frags (via pskb_trim_unique(skb,
> 0)), and then subtracts the old skb->data_len from truesize. This
> adjustment has already be done during trimming (in skb_condense), so
> we don't need to do it again.
>
> This shows up for example when running fragmented traffic over ipcomp,
> we end up hitting the WARN_ON_ONCE in skb_try_coalesce.
>
> Fixes: eb2953d26971 ("xfrm: ipcomp: Use crypto_acomp interface")
> Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
> ---
> net/xfrm/xfrm_ipcomp.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2025-04-26 1:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-25 14:32 [PATCH ipsec] xfrm: ipcomp: fix truesize computation on receive Sabrina Dubroca
2025-04-26 1:53 ` Herbert Xu [this message]
2025-05-05 7:21 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAw8o89W6F9uLuDo@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).