From: Joe Damato <jdamato@fastly.com>
To: Mohsin Bashir <mohsin.bashr@gmail.com>
Cc: netdev@vger.kernel.org, alexanderduyck@fb.com, kuba@kernel.org,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, horms@kernel.org, vadim.fedorenko@linux.dev,
sdf@fomichev.me
Subject: Re: [PATCH net-next] eth: fbnic: fix `tx_dropped` counting
Date: Fri, 2 May 2025 19:58:11 -0700 [thread overview]
Message-ID: <aBWGQ_27ZI7Ti-Z5@LQ3V64L9R2> (raw)
In-Reply-To: <20250503020145.1868252-1-mohsin.bashr@gmail.com>
On Fri, May 02, 2025 at 07:01:45PM -0700, Mohsin Bashir wrote:
> Fix the tracking of rtnl_link_stats.tx_dropped. The counter
> `tmi.drop.frames` is being double counted whereas, the counter
> `tti.cm_drop.frames` is being skipped.
>
> Fixes: f2957147ae7a ("eth: fbnic: add support for TTI HW stats")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Mohsin Bashir <mohsin.bashr@gmail.com>
> ---
> drivers/net/ethernet/meta/fbnic/fbnic_netdev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Joe Damato <jdamato@fastly.com>
next prev parent reply other threads:[~2025-05-03 2:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-03 2:01 [PATCH net-next] eth: fbnic: fix `tx_dropped` counting Mohsin Bashir
2025-05-03 2:58 ` Joe Damato [this message]
2025-05-06 9:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBWGQ_27ZI7Ti-Z5@LQ3V64L9R2 \
--to=jdamato@fastly.com \
--cc=alexanderduyck@fb.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).