Re: [PATCH net v4] net: airoha: Add missing filed to ppe_mbox_data struct

[Lorenzo Bianconi <lorenzo@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 964 bytes --]

On May 02, Jakub Kicinski wrote:
> On Fri, 2 May 2025 09:24:49 +0200 Lorenzo Bianconi wrote:
> > > > What I mean here is the padding in the ppe_mbox_data struct used by the fw running
> > > > on the NPU, not in the version used by the airoha_eth driver, got my point?
> > > > Sorry, re-reading it, it was not so clear, I agree.  
> > > 
> > > You mean adding the "u8 rsv[3];" ? that is fine.
> > > I don't get why we also need to add the 3 __packed  
> > 
> > I agree the __packed attributes are not mandatory at the moment, we just agreed
> > with Jacob that is fine to add them. Do you prefer to get rid of them?
> 
> Yes, they also imply the structure may not be aligned, AFAIU.
> __packed used to be one of DaveM's big no-nos back in the day.
> Especially in vendor drivers it gets sprinkled everywhere without
> thinking. So maybe it's all school of me, but yes, please remove.

ack, fine. I will get rid of them in v5.

Regards,
Lorenzo

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]