From: Moon Yeounsu <yyyynoom@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: dlink: add Kconfig option for RMON registers
Date: Thu, 22 May 2025 15:20:55 +0900 [thread overview]
Message-ID: <aC7CR1ZTaJ7m_Dna@mythos-cloud> (raw)
In-Reply-To: <20250519165758.58157a0b@kernel.org>
On Mon, May 19, 2025 at 04:57:58PM -0700, Jakub Kicinski wrote:
> On Tue, 20 May 2025 06:40:45 +0900 Moon Yeounsu wrote:
> Kconfig is not a great choice for chip specific logic.
> You should check some sort of chip ID register or PCI ID
> to match the chip version at runtime. Most users don't compile
> their own kernels.
Just to confirm. are you suggesting that RMON MMIO should be enabled
only on hardware known to support it correctly, instaed of exposing it
via Kconfig?
Then, I'll drop the Kconfig option and enable RMON MMIO only for
known-good devices via a runtime check. Currently, that's limited to
DGE-550T (`0x4000`) with revision A3 (`0x0c`).
The `dw32(RmonStatMask, 0x0007ffff);` line will also be skipped
accordingly.
Let me know if you have any concerns. Otherwise, I'll send a revisied
patch.
Thank you for reviewing,
Yeounsu
next prev parent reply other threads:[~2025-05-22 6:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-19 21:40 [PATCH net-next] net: dlink: add Kconfig option for RMON registers Moon Yeounsu
2025-05-19 23:57 ` Jakub Kicinski
2025-05-22 6:20 ` Moon Yeounsu [this message]
2025-05-22 15:39 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aC7CR1ZTaJ7m_Dna@mythos-cloud \
--to=yyyynoom@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).