Re: [PATCH net-next 1/4] net: bonding: add broadcast_neighbor option for 802.3ad

[Hangbin Liu <liuhangbin@gmail.com>]

On Sat, May 10, 2025 at 12:45:01PM +0800, tonghao@bamaicloud.com wrote:
> diff --git a/drivers/net/bonding/bond_sysfs.c b/drivers/net/bonding/bond_sysfs.c
> index 1e13bb170515..76f2a1bf57c2 100644
> --- a/drivers/net/bonding/bond_sysfs.c
> +++ b/drivers/net/bonding/bond_sysfs.c
> @@ -752,6 +752,23 @@ static ssize_t bonding_show_ad_user_port_key(struct device *d,
>  static DEVICE_ATTR(ad_user_port_key, 0644,
>  		   bonding_show_ad_user_port_key, bonding_sysfs_store_option);
>  
> +static ssize_t bonding_show_broadcast_neighbor(struct device *d,
> +					       struct device_attribute *attr,
> +					       char *buf)
> +{
> +	struct bonding *bond = to_bond(d);
> +	const struct bond_opt_value *val;
> +
> +	val = bond_opt_get_val(BOND_OPT_BROADCAST_NEIGH,
> +			bond->params.broadcast_neighbor);

nit: please take care of the code alignment here

> +
> +	return sysfs_emit(buf, "%s %d\n", val->string,
> +			bond->params.broadcast_neighbor);

                       here
> +}
> +
> +static DEVICE_ATTR(broadcast_neighbor, 0644,
> +		   bonding_show_broadcast_neighbor, bonding_sysfs_store_option);

and here.

Thanks
Hangbin