From: Stanislav Fomichev <stfomichev@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Michael Chan <michael.chan@broadcom.com>,
davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch,
pavan.chebbi@broadcom.com, andrew.gospodarek@broadcom.com,
sdf@fomichev.me, Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Subject: Re: [PATCH net] bnxt_en: bring back rtnl_lock() in bnxt_fw_reset_task()
Date: Mon, 12 May 2025 18:14:51 -0700 [thread overview]
Message-ID: <aCKdCwjxSLcfw27k@mini-arch> (raw)
In-Reply-To: <20250512172649.31800d90@kernel.org>
On 05/12, Jakub Kicinski wrote:
> On Mon, 12 May 2025 16:43:12 -0700 Stanislav Fomichev wrote:
> > On 05/12, Michael Chan wrote:
> > > On Mon, May 12, 2025 at 7:20 AM Stanislav Fomichev <stfomichev@gmail.com> wrote:
> > > > Will the following work instead? netdev_ops_assert_locked should take
> > > > care of asserting either ops lock or rtnl lock depending on the device
> > > > properties.
> > >
> > > It works for netif_set_real_num_tx_queues() but I also need to replace
> > > the ASSERT_RTNL() with netdev_ops_assert_locked(dev) in
> > > __udp_tunnel_nic_reset_ntf().
> >
> > Sounds good!
>
> Mm... To me it sounds concerning. UDP tunnel port tracking doesn't have
> any locks, it depends on RTNL. Are y'all sure we can just drop the
> ASSERT_RTNL() and nothing will blow up? Or did I misunderstand?
>
> I'd go with Michael's patch for net and revisit in net-next if you're
> filling bold.
Good point. But in this case, we need to cover more? bnxt_open from
bnxt_resume and the callers of bnxt_reset?
next prev parent reply other threads:[~2025-05-13 1:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-12 6:37 [PATCH net] bnxt_en: bring back rtnl_lock() in bnxt_fw_reset_task() Michael Chan
2025-05-12 14:20 ` Stanislav Fomichev
2025-05-12 22:08 ` Michael Chan
2025-05-12 23:43 ` Stanislav Fomichev
2025-05-13 0:26 ` Jakub Kicinski
2025-05-13 1:14 ` Stanislav Fomichev [this message]
2025-05-13 5:41 ` Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCKdCwjxSLcfw27k@mini-arch \
--to=stfomichev@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew.gospodarek@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=kuba@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).