Re: [PATCH net v2] octeontx2-af: Send Link events one by one

[Michal Swiatkowski <michal.swiatkowski@linux.intel.com>]

On Wed, May 14, 2025 at 11:58:28AM +0530, Subbaraya Sundeep wrote:
> Send link events one after another otherwise new message
> is overwriting the message which is being processed by PF.
> 
> Fixes: a88e0f936ba9 ("octeontx2: Detect the mbox up or down message via register")
> Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com>
> ---
> v2:
>  No changes. Added subject prefix net.
> 
>  drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c
> index 992fa0b..ebb56eb 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c
> @@ -272,6 +272,8 @@ static void cgx_notify_pfs(struct cgx_link_event *event, struct rvu *rvu)
>  
>  		otx2_mbox_msg_send_up(&rvu->afpf_wq_info.mbox_up, pfid);
>  
> +		otx2_mbox_wait_for_rsp(&rvu->afpf_wq_info.mbox_up, pfid);
> +
>  		mutex_unlock(&rvu->mbox_lock);

Fix looks fine.
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>

In rvu_rep_up_notify() the same send function is called (and
rvu_rep_up_notify() is called in do, while loop in
rvu_rep_wq_handler()). Doesn't it also need waiting for response?
Are there a message that don't need waiting? Maybe it will be best to
always wait for response if another call can overwrite.

Thanks

>  	} while (pfmap);
>  }
> -- 
> 2.7.4