From: Stanislav Fomichev <stfomichev@gmail.com>
To: Mina Almasry <almasrymina@google.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Jesper Dangaard Brouer <hawk@kernel.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Neal Cardwell <ncardwell@google.com>,
Kuniyuki Iwashima <kuniyu@amazon.com>,
David Ahern <dsahern@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Shuah Khan <shuah@kernel.org>,
sdf@fomichev.me, ap420073@gmail.com, praan@google.com,
shivajikant@google.com
Subject: Re: [PATCH net-next v1 4/9] net: devmem: ksft: remove ksft_disruptive
Date: Mon, 19 May 2025 08:25:20 -0700 [thread overview]
Message-ID: <aCtNYJo01UfMOLfr@mini-arch> (raw)
In-Reply-To: <20250519023517.4062941-5-almasrymina@google.com>
On 05/19, Mina Almasry wrote:
> As far as I can tell the ksft_disruptive here is unnecessary. These
> tests are largerly independent, and when one test fails, it's nice to
> know the results from all the other test cases.
We currently don't do anything special for disruptive tests. I'm assuming
anything that changes nic configuration is disruptive and was thinking of
an option to run all disruptive tests at the end of the run. But so far we
haven't had any problem with mixing disruptive and non-disruptive tests,
so it's all moot. I'd prefer to keep everything as is for now (or remove
this whole disruptive category).
next prev parent reply other threads:[~2025-05-19 15:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-19 2:35 [PATCH net-next v1 0/9] Devmem TCP minor cleanups and ksft improvements Mina Almasry
2025-05-19 2:35 ` [PATCH net-next v1 1/9] net: devmem: move list_add to net_devmem_bind_dmabuf Mina Almasry
2025-05-19 6:45 ` Taehee Yoo
2025-05-19 2:35 ` [PATCH net-next v1 2/9] page_pool: fix ugly page_pool formatting Mina Almasry
2025-05-19 2:35 ` [PATCH net-next v1 3/9] net: devmem: preserve sockc_err Mina Almasry
2025-05-19 15:21 ` Stanislav Fomichev
2025-05-19 2:35 ` [PATCH net-next v1 4/9] net: devmem: ksft: remove ksft_disruptive Mina Almasry
2025-05-19 15:25 ` Stanislav Fomichev [this message]
2025-05-19 17:30 ` Mina Almasry
2025-05-19 20:18 ` Stanislav Fomichev
2025-05-19 23:41 ` Jakub Kicinski
2025-05-19 2:35 ` [PATCH net-next v1 5/9] net: devmem: ksft: add ipv4 support Mina Almasry
2025-05-19 15:32 ` Stanislav Fomichev
2025-05-19 17:31 ` Mina Almasry
2025-05-19 20:26 ` Stanislav Fomichev
2025-05-19 23:48 ` Jakub Kicinski
2025-05-19 2:35 ` [PATCH net-next v1 6/9] net: devmem: ksft: add exit_wait to make rx test pass Mina Almasry
2025-05-19 15:32 ` Stanislav Fomichev
2025-05-19 2:35 ` [PATCH net-next v1 7/9] net: devmem: ksft: add 5 tuple FS support Mina Almasry
2025-05-19 15:37 ` Stanislav Fomichev
2025-05-19 17:32 ` Mina Almasry
2025-05-19 20:26 ` Stanislav Fomichev
2025-05-19 2:35 ` [PATCH net-next v1 8/9] net: devmem: ksft: upgrade rx test to send 1K data Mina Almasry
2025-05-19 15:37 ` Stanislav Fomichev
2025-05-19 2:35 ` [PATCH net-next v1 9/9] net: devmem: ncdevmem: remove unused variable Mina Almasry
2025-05-19 15:37 ` Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCtNYJo01UfMOLfr@mini-arch \
--to=stfomichev@gmail.com \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=ap420073@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=praan@google.com \
--cc=sdf@fomichev.me \
--cc=shivajikant@google.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).