From: Steffen Klassert <steffen.klassert@secunet.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Leon Romanovsky <leonro@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Jakub Kicinski <kuba@kernel.org>, <netdev@vger.kernel.org>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH ipsec-next] xfrm: validate assignment of maximal possible SEQ number
Date: Tue, 20 May 2025 07:52:15 +0200 [thread overview]
Message-ID: <aCwYj1F3LSUVZRg7@gauss3.secunet.de> (raw)
In-Reply-To: <956dde412bb3224a31bf89a3038b9d2c76890a42.1747133660.git.leon@kernel.org>
On Tue, May 13, 2025 at 01:56:22PM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
>
> Users can set any seq/seq_hi/oseq/oseq_hi values. The XFRM core code
> doesn't prevent from them to set even 0xFFFFFFFF, however this value
> will cause for traffic drop.
>
> Is is happening because SEQ numbers here mean that packet with such
> number was processed and next number should be sent on the wire. In this
> case, the next number will be 0, and it means overflow which causes to
> (expected) packet drops.
>
> While it can be considered as misconfiguration and handled by XFRM
> datapath in the same manner as any other SEQ number, let's add
> validation to easy for packet offloads implementations which need to
> configure HW with next SEQ to send and not with current SEQ like it is
> done in core code.
>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
Applied, thanks Leon!
prev parent reply other threads:[~2025-05-20 5:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-13 10:56 [PATCH ipsec-next] xfrm: validate assignment of maximal possible SEQ number Leon Romanovsky
2025-05-20 5:52 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCwYj1F3LSUVZRg7@gauss3.secunet.de \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=leonro@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).