Re: [PATCH AUTOSEL 6.14 519/642] net: ethtool: prevent flow steering to RSS contexts which don't exist

Sasha Levin
2025-05-20T14:11:15Z

On Tue, May 06, 2025 at 09:31:55AM +0300, Gal Pressman wrote:
>On 06/05/2025 1:12, Sasha Levin wrote:
>> From: Jakub Kicinski <kuba@kernel.org>
>>
>> [ Upstream commit de7f7582dff292832fbdeaeff34e6b2ee6f9f95f ]
>>
>> Since commit 42dc431f5d0e ("ethtool: rss: prevent rss ctx deletion
>> when in use") we prevent removal of RSS contexts pointed to by
>> existing flow rules. Core should also prevent creation of rules
>> which point to RSS context which don't exist in the first place.
>>
>> Reviewed-by: Joe Damato <jdamato@fastly.com>
>> Link: https://patch.msgid.link/20250206235334.1425329-2-kuba@kernel.org
>> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
>> Signed-off-by: Sasha Levin <sashal@kernel.org>
>
>This patch caused a user-visible regression, I don't recommend taking it
>to stable.
>
>FWIW, I tried to fix it:
>https://lore.kernel.org/netdev/20250225071348.509432-1-gal@nvidia.com/

I'll drop it, thanks!

--
Thanks,
Sasha