* Re: [PATCH net-next] net/mlx5: HWS, Fix an error code in mlx5hws_bwc_rule_create_complex()
2025-05-23 16:00 [PATCH net-next] net/mlx5: HWS, Fix an error code in mlx5hws_bwc_rule_create_complex() Dan Carpenter
@ 2025-05-25 9:34 ` Yevgeny Kliteynik
2025-05-26 6:24 ` Tariq Toukan
2025-05-28 1:20 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Yevgeny Kliteynik @ 2025-05-25 9:34 UTC (permalink / raw)
To: Dan Carpenter
Cc: Saeed Mahameed, Leon Romanovsky, Tariq Toukan, Andrew Lunn,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Cosmin Ratiu, Mark Bloch, Vlad Dogaru, netdev, linux-rdma,
linux-kernel, kernel-janitors
On 23-May-25 19:00, Dan Carpenter wrote:
> This was intended to be negative -ENOMEM but the '-' character was left
> off accidentally. This typo doesn't affect runtime because the caller
> treats all non-zero returns the same.
>
> Fixes: 17e0accac577 ("net/mlx5: HWS, support complex matchers")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> .../net/ethernet/mellanox/mlx5/core/steering/hws/bwc_complex.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc_complex.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc_complex.c
> index 5d30c5b094fc..70768953a4f6 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc_complex.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc_complex.c
> @@ -1188,7 +1188,7 @@ int mlx5hws_bwc_rule_create_complex(struct mlx5hws_bwc_rule *bwc_rule,
> GFP_KERNEL);
> if (unlikely(!match_buf_2)) {
> mlx5hws_err(ctx, "Complex rule: failed allocating match_buf\n");
> - ret = ENOMEM;
> + ret = -ENOMEM;
> goto hash_node_put;
> }
>
Reviewed-by: Yevgeny Kliteynik <kliteyn@nvidia.com>
Thanks Dan.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next] net/mlx5: HWS, Fix an error code in mlx5hws_bwc_rule_create_complex()
2025-05-23 16:00 [PATCH net-next] net/mlx5: HWS, Fix an error code in mlx5hws_bwc_rule_create_complex() Dan Carpenter
2025-05-25 9:34 ` Yevgeny Kliteynik
@ 2025-05-26 6:24 ` Tariq Toukan
2025-05-28 1:20 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Tariq Toukan @ 2025-05-26 6:24 UTC (permalink / raw)
To: Dan Carpenter, Yevgeny Kliteynik
Cc: Saeed Mahameed, Leon Romanovsky, Tariq Toukan, Andrew Lunn,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Cosmin Ratiu, Mark Bloch, Vlad Dogaru, netdev, linux-rdma,
linux-kernel, kernel-janitors
On 23/05/2025 19:00, Dan Carpenter wrote:
> This was intended to be negative -ENOMEM but the '-' character was left
> off accidentally. This typo doesn't affect runtime because the caller
> treats all non-zero returns the same.
>
> Fixes: 17e0accac577 ("net/mlx5: HWS, support complex matchers")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> .../net/ethernet/mellanox/mlx5/core/steering/hws/bwc_complex.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc_complex.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc_complex.c
> index 5d30c5b094fc..70768953a4f6 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc_complex.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc_complex.c
> @@ -1188,7 +1188,7 @@ int mlx5hws_bwc_rule_create_complex(struct mlx5hws_bwc_rule *bwc_rule,
> GFP_KERNEL);
> if (unlikely(!match_buf_2)) {
> mlx5hws_err(ctx, "Complex rule: failed allocating match_buf\n");
> - ret = ENOMEM;
> + ret = -ENOMEM;
> goto hash_node_put;
> }
>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next] net/mlx5: HWS, Fix an error code in mlx5hws_bwc_rule_create_complex()
2025-05-23 16:00 [PATCH net-next] net/mlx5: HWS, Fix an error code in mlx5hws_bwc_rule_create_complex() Dan Carpenter
2025-05-25 9:34 ` Yevgeny Kliteynik
2025-05-26 6:24 ` Tariq Toukan
@ 2025-05-28 1:20 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-05-28 1:20 UTC (permalink / raw)
To: Dan Carpenter
Cc: kliteyn, saeedm, leon, tariqt, andrew+netdev, davem, edumazet,
kuba, pabeni, cratiu, mbloch, vdogaru, netdev, linux-rdma,
linux-kernel, kernel-janitors
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 23 May 2025 19:00:12 +0300 you wrote:
> This was intended to be negative -ENOMEM but the '-' character was left
> off accidentally. This typo doesn't affect runtime because the caller
> treats all non-zero returns the same.
>
> Fixes: 17e0accac577 ("net/mlx5: HWS, support complex matchers")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
>
> [...]
Here is the summary with links:
- [net-next] net/mlx5: HWS, Fix an error code in mlx5hws_bwc_rule_create_complex()
https://git.kernel.org/netdev/net-next/c/a540ee75945a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread