Netdev List
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: netfilter-devel@vger.kernel.org, Phil Sutter <phil@nwl.cc>,
	davem@davemloft.net, netdev@vger.kernel.org, kuba@kernel.org,
	edumazet@google.com, fw@strlen.de, horms@kernel.org
Subject: Re: [PATCH net-next 26/26] selftests: netfilter: Torture nftables netdev hooks
Date: Tue, 27 May 2025 10:39:20 +0200	[thread overview]
Message-ID: <aDV6OA2G99L4Xvuk@calendula> (raw)
In-Reply-To: <12b16f0b-8ba8-4077-9a13-0bc514e1cd44@redhat.com>

Hi Paolo,

On Tue, May 27, 2025 at 09:17:30AM +0200, Paolo Abeni wrote:
> On 5/23/25 3:27 PM, Pablo Neira Ayuso wrote:
> > +ip netns exec $nsr nft -f - <<EOF
> > +table ip t {
> > +	flowtable ft_wild {
> > +		hook ingress priority 0
> > +		devices = { wild* }
> > +	}
> > +}
> > +EOF
> 
> The above is causing CI failures:
> 
> # selftests: net/netfilter: nft_interface_stress.sh
> # /dev/stdin:4:15-19: Error: syntax error, unexpected string with a
> trailing asterisk, expecting string or quoted string or '$'
> # devices = { wild* }
> #             ^^^^^
> not ok 1 selftests: net/netfilter: nft_interface_stress.sh # exit=1
> 
> For some reasons (likely PEBKAC here...) I did not catch that before
> merging the PR, please try to follow-up soon. Thanks,

This needs userspace updates in libnftnl and nftables.

I am looking at the best way to address this.

Q: is CI getting a fresh clone from netfilter git repositories?

Thanks.

  reply	other threads:[~2025-05-27  8:39 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-23 13:26 [PATCH net-next,v2 00/26] Netfilter updates for net-next Pablo Neira Ayuso
2025-05-23 13:26 ` [PATCH net-next 01/26] selftests: netfilter: nft_concat_range.sh: add coverage for 4bit group representation Pablo Neira Ayuso
2025-05-26 17:11   ` patchwork-bot+netdevbpf
2025-05-23 13:26 ` [PATCH net-next 02/26] netfilter: xtables: support arpt_mark and ipv6 optstrip for iptables-nft only builds Pablo Neira Ayuso
2025-05-23 13:26 ` [PATCH net-next 03/26] selftests: netfilter: nft_fib.sh: add 'type' mode tests Pablo Neira Ayuso
2025-05-23 13:26 ` [PATCH net-next 04/26] selftests: netfilter: move fib vrf test to nft_fib.sh Pablo Neira Ayuso
2025-05-23 13:26 ` [PATCH net-next 05/26] netfilter: nf_tables: nft_fib_ipv6: fix VRF ipv4/ipv6 result discrepancy Pablo Neira Ayuso
2025-05-23 13:26 ` [PATCH net-next 06/26] netfilter: nf_tables: nft_fib: consistent l3mdev handling Pablo Neira Ayuso
2025-05-23 13:26 ` [PATCH net-next 07/26] selftests: netfilter: nft_fib.sh: add type and oif tests with and without VRFs Pablo Neira Ayuso
2025-05-23 13:26 ` [PATCH net-next 08/26] netfilter: nft_tunnel: fix geneve_opt dump Pablo Neira Ayuso
2025-05-23 13:26 ` [PATCH net-next 09/26] netfilter: nf_dup{4, 6}: Move duplication check to task_struct Pablo Neira Ayuso
2025-05-23 13:26 ` [PATCH net-next 10/26] netfilter: nft_inner: Use nested-BH locking for nft_pcpu_tun_ctx Pablo Neira Ayuso
2025-05-23 13:26 ` [PATCH net-next 11/26] netfilter: nf_dup_netdev: Move the recursion counter struct netdev_xmit Pablo Neira Ayuso
2025-05-23 13:26 ` [PATCH net-next 12/26] netfilter: conntrack: make nf_conntrack_id callable without a module dependency Pablo Neira Ayuso
2025-05-23 13:26 ` [PATCH net-next 13/26] netfilter: nf_tables: add packets conntrack state to debug trace info Pablo Neira Ayuso
2025-05-23 13:27 ` [PATCH net-next 14/26] netfilter: nf_tables: Introduce functions freeing nft_hook objects Pablo Neira Ayuso
2025-05-23 13:27 ` [PATCH net-next 15/26] netfilter: nf_tables: Introduce nft_hook_find_ops{,_rcu}() Pablo Neira Ayuso
2025-05-23 13:27 ` [PATCH net-next 16/26] netfilter: nf_tables: Introduce nft_register_flowtable_ops() Pablo Neira Ayuso
2025-05-23 13:27 ` [PATCH net-next 17/26] netfilter: nf_tables: Pass nf_hook_ops to nft_unregister_flowtable_hook() Pablo Neira Ayuso
2025-05-23 13:27 ` [PATCH net-next 18/26] netfilter: nf_tables: Have a list of nf_hook_ops in nft_hook Pablo Neira Ayuso
2025-05-23 13:27 ` [PATCH net-next 19/26] netfilter: nf_tables: Prepare for handling NETDEV_REGISTER events Pablo Neira Ayuso
2025-05-23 13:27 ` [PATCH net-next 20/26] netfilter: nf_tables: Respect " Pablo Neira Ayuso
2025-05-23 13:27 ` [PATCH net-next 21/26] netfilter: nf_tables: Wrap netdev notifiers Pablo Neira Ayuso
2025-05-23 13:27 ` [PATCH net-next 22/26] netfilter: nf_tables: Handle NETDEV_CHANGENAME events Pablo Neira Ayuso
2025-05-23 13:27 ` [PATCH net-next 23/26] netfilter: nf_tables: Sort labels in nft_netdev_hook_alloc() Pablo Neira Ayuso
2025-05-23 13:27 ` [PATCH net-next 24/26] netfilter: nf_tables: Support wildcard netdev hook specs Pablo Neira Ayuso
2025-05-23 13:27 ` [PATCH net-next 25/26] netfilter: nf_tables: Add notifications for hook changes Pablo Neira Ayuso
2025-05-23 13:27 ` [PATCH net-next 26/26] selftests: netfilter: Torture nftables netdev hooks Pablo Neira Ayuso
2025-05-27  7:17   ` Paolo Abeni
2025-05-27  8:39     ` Pablo Neira Ayuso [this message]
2025-05-27 14:06       ` Jakub Kicinski
  -- strict thread matches above, loose matches on Subject: below --
2025-05-22 16:52 [PATCH net-next 00/26] Netfilter updates for net-next Pablo Neira Ayuso
2025-05-22 16:52 ` [PATCH net-next 26/26] selftests: netfilter: Torture nftables netdev hooks Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aDV6OA2G99L4Xvuk@calendula \
    --to=pablo@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=fw@strlen.de \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=phil@nwl.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox