Re: [PATCH 6/8] net: tcp: tsq: Convert from tasklet to BH workqueue

[Tejun Heo <tj@kernel.org>]

Hello,

On Sun, May 25, 2025 at 11:51:55AM +0800, Jason Xing wrote:
> Sorry to revive the old thread! I noticed this change because I've
> been doing an investigation around TSQ recently. I'm very cautious
> about the change in the core/sensitive part of the networking area
> because it might affect some corner cases beyond our limited test,
> even though I've tested many rounds and no regression results
> (including the latency between tcp_wfree and tcp_tsq_handler) show up.
> My main concern is what the exact benefit/improvement it could bring
> with the change applied since your BH workqueue commit[1] says the
> tasklet mechanism has some flaws. I'd like to see if I can
> reproduce/verify it.

There won't be any behavioral benefits. It's mostly that it'd be great to
get rid of tasklets with something which is more generic, so if BH workqueue
doesn't regress, we want to keep moving users to BH workqueue until all
tasklet users are gone and then remove tasklet.

Thanks.

-- 
tejun