From: Subbaraya Sundeep <sbhatta@marvell.com>
To: Simon Horman <horms@kernel.org>
Cc: <andrew+netdev@lunn.ch>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<saikrishnag@marvell.com>, <gakula@marvell.com>,
<hkelam@marvell.com>, <sgoutham@marvell.com>,
<lcherian@marvell.com>, <bbhushan2@marvell.com>,
<jerinj@marvell.com>, <netdev@vger.kernel.org>
Subject: Re: [net PATCH] octeontx2: Annotate mmio regions as __iomem
Date: Thu, 29 May 2025 07:07:06 +0000 [thread overview]
Message-ID: <aDgHmiE1bdvc4IgI@e6bae70a73d4> (raw)
In-Reply-To: <20250528145747.GA1484967@horms.kernel.org>
Hi Simon,
On 2025-05-28 at 14:57:47, Simon Horman (horms@kernel.org) wrote:
> On Wed, May 28, 2025 at 10:45:27AM +0530, Subbaraya Sundeep wrote:
> > This patch removes unnecessary typecasts by marking the
> > mbox_regions array as __iomem since it is used to store
> > pointers to memory-mapped I/O (MMIO) regions. Also simplified
> > the call to readq() in PF driver by removing redundant type casts.
> >
> > Fixes: 98c561116360 ("octeontx2-af: cn10k: Add mbox support for CN10K platform")
> > Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com>
>
> Thanks Subbaraya,
>
> As per my comment on [1], I wonder if this is more of a clean-up
> for net-next (once it re-opens, no Fixes tag) than a fix.
>
> [1] Re: [net v2 PATCH] octeontx2-pf: Avoid typecasts by simplifying otx2_atomic64_add macro
> https://lore.kernel.org/netdev/20250528125501.GC365796@horms.kernel.org/T/#t
>
Sure.
Thanks,
Sundeep
> ...
prev parent reply other threads:[~2025-05-29 7:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-28 5:15 [net PATCH] octeontx2: Annotate mmio regions as __iomem Subbaraya Sundeep
2025-05-28 14:57 ` Simon Horman
2025-05-29 7:07 ` Subbaraya Sundeep [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDgHmiE1bdvc4IgI@e6bae70a73d4 \
--to=sbhatta@marvell.com \
--cc=andrew+netdev@lunn.ch \
--cc=bbhushan2@marvell.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=horms@kernel.org \
--cc=jerinj@marvell.com \
--cc=kuba@kernel.org \
--cc=lcherian@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saikrishnag@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox