From: Joe Damato <jdamato@fastly.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: mkubecek@suse.cz, danieller@nvidia.com, idosch@idosch.org,
netdev@vger.kernel.org
Subject: Re: [PATCH ethtool 0/2] module_common: adjust the JSON output for per-lane signals
Date: Thu, 29 May 2025 16:02:23 -0700 [thread overview]
Message-ID: <aDjnf-OMI9Ot2pC5@LQ3V64L9R2> (raw)
In-Reply-To: <20250529142033.2308815-1-kuba@kernel.org>
On Thu, May 29, 2025 at 07:20:31AM -0700, Jakub Kicinski wrote:
> I got some feedback from users trying to integrate the SFP JSON
> output to Meta's monitoring systems. The loss / fault signals
> are currently a bit awkward to parse. This patch set changes
> the format, is it still okay to merge it (as a fix?)
> I think it's a worthwhile improvement, not sure how many people
> depend on the current JSON format after 1 release..
>
> Jakub Kicinski (2):
> module_common: always print per-lane status in JSON
> module_common: print loss / fault signals as bool
>
> module-common.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
Code seems reasonable to me; no idea on whether its still okay to
merge as a fix, but I agree it seems like a worthwhile improvement.
Reviewed-by: Joe Damato <jdamato@fastly.com>
next prev parent reply other threads:[~2025-05-29 23:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-29 14:20 [PATCH ethtool 0/2] module_common: adjust the JSON output for per-lane signals Jakub Kicinski
2025-05-29 14:20 ` [PATCH ethtool 1/2] module_common: always print per-lane status in JSON Jakub Kicinski
2025-05-29 15:53 ` Ido Schimmel
2025-05-29 14:20 ` [PATCH ethtool 2/2] module_common: print loss / fault signals as bool Jakub Kicinski
2025-05-29 15:53 ` Ido Schimmel
2025-05-29 23:02 ` Joe Damato [this message]
2025-05-30 11:35 ` [PATCH ethtool 0/2] module_common: adjust the JSON output for per-lane signals Michal Kubecek
2025-05-31 1:20 ` Jakub Kicinski
2025-06-10 23:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDjnf-OMI9Ot2pC5@LQ3V64L9R2 \
--to=jdamato@fastly.com \
--cc=danieller@nvidia.com \
--cc=idosch@idosch.org \
--cc=kuba@kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox