From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Chris Morgan <macroalpha82@gmail.com>
Cc: netdev@vger.kernel.org, andrew@lunn.ch, hkallweit1@gmail.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [PATCH] net: sfp: add quirk for Potron SFP+ XGSPON ONU Stick
Date: Thu, 5 Jun 2025 23:38:48 +0100 [thread overview]
Message-ID: <aEIceGDOnLsEeoo_@shell.armlinux.org.uk> (raw)
In-Reply-To: <20250605221730.398665-1-macroalpha82@gmail.com>
On Thu, Jun 05, 2025 at 05:17:30PM -0500, Chris Morgan wrote:
> +static void sfp_fixup_potron(struct sfp *sfp)
> +{
> + /*
> + * The TX_FAULT and LOS pins on this device are used for serial
> + * communication, so ignore them. Additionally, provide extra
> + * time for this device to fully start up.
> + */
> +
> + sfp_fixup_long_startup(sfp);
> + sfp->state_hw_mask &= ~(SFP_F_TX_FAULT | SFP_F_LOS);
This should be calling sfp_fixup_ignore_tx_fault(), and possibly
sfp_fixup_ignore_los() as well if the module also reports incorrect
soft LOS state or doesn't support soft LOS state reporting.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
prev parent reply other threads:[~2025-06-05 22:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-05 22:17 [PATCH] net: sfp: add quirk for Potron SFP+ XGSPON ONU Stick Chris Morgan
2025-06-05 22:38 ` Russell King (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEIceGDOnLsEeoo_@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=macroalpha82@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).