public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@nvidia.com>
To: Petr Machata <petrm@nvidia.com>
Cc: David Ahern <dsahern@gmail.com>,
	netdev@vger.kernel.org, Nikolay Aleksandrov <razor@blackwall.org>
Subject: Re: [PATCH iproute2-next 4/4] ip: iplink_bridge: Support bridge VLAN stats in `ip stats'
Date: Sun, 8 Jun 2025 17:44:28 +0300	[thread overview]
Message-ID: <aEWhzO9WUiwZsaGl@shredder> (raw)
In-Reply-To: <997a47a1dcd139a0e50ea4a448b45612b58eac69.1749220201.git.petrm@nvidia.com>

On Fri, Jun 06, 2025 at 05:04:53PM +0200, Petr Machata wrote:
> +static const struct ipstats_stat_desc_xstats
> +ipstats_stat_desc_xstats_slave_bridge_vlan = {
> +	.desc = {
> +		.name = "vlan",
> +		.kind = IPSTATS_STAT_DESC_KIND_LEAF,
> +		.show = &bridge_stat_desc_show_xstats,
> +		.pack = &ipstats_stat_desc_pack_xstats,
> +	},
> +	.xstats_at = IFLA_STATS_LINK_XSTATS_SLAVE,

This will only show VLAN stats for bridge ports, but they also exist for
the bridge itself inside the IFLA_STATS_LINK_XSTATS nest

> +	.link_type_at = LINK_XSTATS_TYPE_BRIDGE,
> +	.inner_at = BRIDGE_XSTATS_VLAN,
> +	.show_cb = &bridge_print_stats_vlan,
> +};

  reply	other threads:[~2025-06-08 14:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-06 15:04 [PATCH iproute2-next 0/4] ip: Support bridge VLAN stats in `ip stats' Petr Machata
2025-06-06 15:04 ` [PATCH iproute2-next 1/4] ip: ipstats: Iterate all xstats attributes Petr Machata
2025-06-08 14:23   ` Ido Schimmel
2025-06-09 14:10     ` Petr Machata
2025-06-06 15:04 ` [PATCH iproute2-next 2/4] ip: ip_common: Drop ipstats_stat_desc_xstats::inner_max Petr Machata
2025-06-08 14:24   ` Ido Schimmel
2025-06-06 15:04 ` [PATCH iproute2-next 3/4] lib: bridge: Add a module for bridge-related helpers Petr Machata
2025-06-06 15:32   ` Nikolay Aleksandrov
2025-06-09 13:39     ` Petr Machata
2025-06-08 14:26   ` Ido Schimmel
2025-06-09 14:42     ` Petr Machata
2025-06-06 15:04 ` [PATCH iproute2-next 4/4] ip: iplink_bridge: Support bridge VLAN stats in `ip stats' Petr Machata
2025-06-08 14:44   ` Ido Schimmel [this message]
2025-06-09 14:10     ` Petr Machata

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aEWhzO9WUiwZsaGl@shredder \
    --to=idosch@nvidia.com \
    --cc=dsahern@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=petrm@nvidia.com \
    --cc=razor@blackwall.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox