From: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
To: Li Jun <lijun01@kylinos.cn>
Cc: davem@davemloft.net, edumazet@google.com, netdev@vger.kernel.org,
michal.swiatkowski@linux.intel.com, horms@kernel.org
Subject: Re: [PATCH net-next] net: ppp: remove error variable
Date: Mon, 9 Jun 2025 08:24:26 +0200 [thread overview]
Message-ID: <aEZ+GhgNtYS2E7yy@mev-dev.igk.intel.com> (raw)
In-Reply-To: <20250609005143.23946-1-lijun01@kylinos.cn>
On Mon, Jun 09, 2025 at 08:51:43AM +0800, Li Jun wrote:
> the error variable did not function as a variable.
> so remove it.
>
> Signed-off-by: Li Jun <lijun01@kylinos.cn>
> ---
> drivers/net/ppp/pptp.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ppp/pptp.c b/drivers/net/ppp/pptp.c
> index 5feaa70b5f47..67239476781e 100644
> --- a/drivers/net/ppp/pptp.c
> +++ b/drivers/net/ppp/pptp.c
> @@ -501,7 +501,6 @@ static int pptp_release(struct socket *sock)
> {
> struct sock *sk = sock->sk;
> struct pppox_sock *po;
> - int error = 0;
>
> if (!sk)
> return 0;
> @@ -526,7 +525,7 @@ static int pptp_release(struct socket *sock)
> release_sock(sk);
> sock_put(sk);
>
> - return error;
> + return 0;
> }
>
> static void pptp_sock_destruct(struct sock *sk)
Right,
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> --
> 2.25.1
>
next prev parent reply other threads:[~2025-06-09 6:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-09 0:51 [PATCH net-next] net: ppp: remove error variable Li Jun
2025-06-09 6:24 ` Michal Swiatkowski [this message]
2025-06-09 6:38 ` Subbaraya Sundeep
2025-06-09 19:37 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEZ+GhgNtYS2E7yy@mev-dev.igk.intel.com \
--to=michal.swiatkowski@linux.intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=lijun01@kylinos.cn \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).