From: Breno Leitao <leitao@debian.org>
To: Gustavo Luiz Duarte <gustavold@gmail.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] netconsole: fix appending sysdata when sysdata_fields == SYSDATA_RELEASE
Date: Tue, 10 Jun 2025 01:06:24 -0700 [thread overview]
Message-ID: <aEfngKdDKgQH2yZq@gmail.com> (raw)
In-Reply-To: <20250609-netconsole-fix-v1-1-17543611ae31@gmail.com>
On Mon, Jun 09, 2025 at 11:24:20AM -0700, Gustavo Luiz Duarte wrote:
> Before appending sysdata, prepare_extradata() checks if any feature is
> enabled in sysdata_fields (and exits early if none is enabled).
>
> When SYSDATA_RELEASE was introduced, we missed adding it to the list of
> features being checked against sysdata_fields in prepare_extradata().
> The result was that, if only SYSDATA_RELEASE is enabled in
> sysdata_fields, we incorreclty exit early and fail to append the
> release.
>
> Instead of checking specific bits in sysdata_fields, check if
> sysdata_fields has ALL bit zeroed and exit early if true. This fixes
> case when only SYSDATA_RELEASE enabled and makes the code more general /
> less error prone in future feature implementation.
>
> Signed-off-by: Gustavo Luiz Duarte <gustavold@gmail.com>
Fixes: dd30ae533242 ("netconsole: append release to sysdata")
Reviewed-by: Breno Leitao <leitao@debian.org>
Thanks for the fix,
--breno
next prev parent reply other threads:[~2025-06-10 8:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-09 18:24 [PATCH net] netconsole: fix appending sysdata when sysdata_fields == SYSDATA_RELEASE Gustavo Luiz Duarte
2025-06-10 8:06 ` Breno Leitao [this message]
2025-06-10 23:39 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEfngKdDKgQH2yZq@gmail.com \
--to=leitao@debian.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gustavold@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).