Re: [PATCH RFC net-next v2] page_pool: import Jesper's page_pool benchmark

[Arnaldo Carvalho de Melo <acme@kernel.org>]

On Tue, Jun 10, 2025 at 10:41:49AM +0300, Ilias Apalodimas wrote:
> On Wed, 4 Jun 2025 at 11:39, Jesper Dangaard Brouer <hawk@kernel.org> wrote:
> > Okay, I think Ilias'es comment[1] and ACK convinced me, let us merge
> > this as-is.  We have been asking people to run it over several years
> > before accepting patches. We shouldn't be pointing people to use
> > out-of-tree tests for accepting patches.

> > It is not perfect, but it have served us well for benchmarking in the
> > last approx 10 years (5 years for page_pool test).  It is isolated as a
> > selftest under (tools/testing/selftests/net/bench/page_pool/).

> > Realistically we are all too busy inventing a new "perfect" benchmark
> > for page_pool. That said, I do encourage others with free cycles to
> > integrated a better benchmark test into `perf bench`.  Then we can just
> > remove this module again.

> I'll spend some time looking at acme comments. They seem to be moving
> towards the right direction

Glad that you think that way, and to add another perspective, 'perf
test' and 'perf bench' goals are to run in any kernel, not just some
specific one where a regression was fixed, so people running plain 'perf
bench' will run whatever tests we add and thus widen the tester base for
the benchmarks in there.

Being able to combine 'perf trace perf bench', 'perf stat perf bench',
etc is something common and powerful.

But then the most important thing is to have actionable and expertly
written benchmarks in place, that have been in use for a long time, in
whatever form :-)

- Arnaldo