From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A3D5265CBA; Tue, 10 Jun 2025 20:33:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749587592; cv=none; b=Preq0fmT5bkq8RXgJfYZVPBq7FcWw1IyJ2p3Lc/pJ71FM2HkvpY+tWB5mD/9J+J7uqW7hMwvdZh5MfSbqZdxpjtsYoGrUjuvJ5hcQU0NRBkEL+oBdn/LwnvD/2LL1MdLZqbKRxZS+joG86F0KBPYcpklj3Qk/JsX4kSUKhdqCpQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749587592; c=relaxed/simple; bh=YqAtRU+UI0vXzRiV4CZ1vJF79I1Ncsncog4Fc6hDRkY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lLnxFFamVn4pamC291uH5HE1Jf7SWEyM7XrfOR9BjaxaO7APacjptsX38CCK28D+mMPe0hzsVAoUmI/1drZ8O24P2KJgM5jY0EQLqQsSqrxvWMDxq13jAJ757uykKH3gr0hr1icTSjQyEBCy86aVEJox1ONP11bn8BV9QzT5Rp4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nztG3FBU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nztG3FBU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB3C1C4CEED; Tue, 10 Jun 2025 20:33:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749587592; bh=YqAtRU+UI0vXzRiV4CZ1vJF79I1Ncsncog4Fc6hDRkY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nztG3FBUb/dwPMNltE4uTNKS6+qtHQthGNxdk30oHQc+8V4GL6FBuDFRsKOH4ojYE 86oNZJTgxlaa8pE1CauiNCy3E9PEbjEautOmloD/LiGyfC50l8tcqf3es32a9cCEcx igKawOiVs2S81NCqwrDMLY8FppIcKatwxWV4UKxIWOlBPLP9GdNp4Nc4vx86PZdPgm u/WIFoJA4MJbqBsRJZV2XTv0S46Z3xQ3vTNpo1WvkSb0M8aErLY4so3OR6wgXCW0bC BrrTyLAmho4mXUJ2uUABD+0NsCyHVJEsCrg94flPMxsGZKD/L87+KbhsB5iJJXkooL w+/LgGQWRUR1g== Date: Tue, 10 Jun 2025 17:33:09 -0300 From: Arnaldo Carvalho de Melo To: Ilias Apalodimas Cc: Jesper Dangaard Brouer , Mina Almasry , Toke =?iso-8859-1?Q?H=F8iland-J=F8rgensen?= , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Shuah Khan Subject: Re: [PATCH RFC net-next v2] page_pool: import Jesper's page_pool benchmark Message-ID: References: <20250525034354.258247-1-almasrymina@google.com> <87iklna61r.fsf@toke.dk> <87h615m6cp.fsf@toke.dk> <6fd8b288-2719-424b-92d2-3dcfe03bbaef@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jun 10, 2025 at 10:41:49AM +0300, Ilias Apalodimas wrote: > On Wed, 4 Jun 2025 at 11:39, Jesper Dangaard Brouer wrote: > > Okay, I think Ilias'es comment[1] and ACK convinced me, let us merge > > this as-is. We have been asking people to run it over several years > > before accepting patches. We shouldn't be pointing people to use > > out-of-tree tests for accepting patches. > > It is not perfect, but it have served us well for benchmarking in the > > last approx 10 years (5 years for page_pool test). It is isolated as a > > selftest under (tools/testing/selftests/net/bench/page_pool/). > > Realistically we are all too busy inventing a new "perfect" benchmark > > for page_pool. That said, I do encourage others with free cycles to > > integrated a better benchmark test into `perf bench`. Then we can just > > remove this module again. > I'll spend some time looking at acme comments. They seem to be moving > towards the right direction Glad that you think that way, and to add another perspective, 'perf test' and 'perf bench' goals are to run in any kernel, not just some specific one where a regression was fixed, so people running plain 'perf bench' will run whatever tests we add and thus widen the tester base for the benchmarks in there. Being able to combine 'perf trace perf bench', 'perf stat perf bench', etc is something common and powerful. But then the most important thing is to have actionable and expertly written benchmarks in place, that have been in use for a long time, in whatever form :-) - Arnaldo