From: Paul Fertser <fercerpav@gmail.com>
To: kalavakunta.hari.prasad@gmail.com
Cc: sam@mendozajonas.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
npeacock@meta.com, hkalavakunta@meta.com
Subject: Re: [PATCH net-next] net: ncsi: Fix buffer overflow in fetching version id
Date: Wed, 11 Jun 2025 12:09:01 +0300 [thread overview]
Message-ID: <aElHrRb5Vk7PzEAs@home.paul.comp> (raw)
In-Reply-To: <20250610193338.1368-1-kalavakunta.hari.prasad@gmail.com>
Hello Hari,
On Tue, Jun 10, 2025 at 12:33:38PM -0700, kalavakunta.hari.prasad@gmail.com wrote:
> From: Hari Kalavakunta <kalavakunta.hari.prasad@gmail.com>
>
> In NC-SI spec v1.2 section 8.4.44.2, the firmware name doesn't
> need to be null terminated while its size occupies the full size
> of the field. Fix the buffer overflow issue by adding one
> additional byte for null terminator.
>
> Signed-off-by: Hari Kalavakunta <kalavakunta.hari.prasad@gmail.com>
You seem to be surprisingly persistent about ignoring my remarks on
your commit message.
So be it, since the code looks correct and reliable, fixes a real life
bug, and actually applies to the right tree now,
Reviewed-by: Paul Fertser <fercerpav@gmail.com>
next prev parent reply other threads:[~2025-06-11 9:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 19:33 [PATCH net-next] net: ncsi: Fix buffer overflow in fetching version id kalavakunta.hari.prasad
2025-06-11 9:09 ` Paul Fertser [this message]
2025-06-13 1:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aElHrRb5Vk7PzEAs@home.paul.comp \
--to=fercerpav@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkalavakunta@meta.com \
--cc=horms@kernel.org \
--cc=kalavakunta.hari.prasad@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=npeacock@meta.com \
--cc=pabeni@redhat.com \
--cc=sam@mendozajonas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox