From: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
To: Jijie Shao <shaojijie@huawei.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
shenjian15@huawei.com, wangpeiyang1@huawei.com,
liuyonglong@huawei.com, chenhao418@huawei.com,
jonathan.cameron@huawei.com,
shameerali.kolothum.thodi@huawei.com, salil.mehta@huawei.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/8] net: hns3: add the hns3_get_ae_dev() helper
Date: Thu, 12 Jun 2025 13:16:40 +0200 [thread overview]
Message-ID: <aEq3DgCDh98Deidl@mev-dev.igk.intel.com> (raw)
In-Reply-To: <20250612021317.1487943-3-shaojijie@huawei.com>
On Thu, Jun 12, 2025 at 10:13:11AM +0800, Jijie Shao wrote:
> This patch introduces a hns3_get_ae_dev() helper to reduce the unnecessary
> middle layer conversion. Apply it to the whole HNS3 driver.
> The former discusstion can be checked from the link.
The definition already exist, so more like "use hns3_get_ae_dev()
wherever possible".
>
> Link: https://patchwork.kernel.org/project/netdevbpf/patch/20230310081404.947-1-lanhao@huawei.com/
I think the comment is about going from netdev to your private
hnae3_ae_dev. You need hnae3_netdev_to_dev/pf/whatever().
Using already defined helper is fine, just please change the commit
message/title.
> Signed-off-by: Jijie Shao <shaojijie@huawei.com>
[...]
next prev parent reply other threads:[~2025-06-12 11:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-12 2:13 [PATCH net-next 0/8] There are some cleanup for hns3 driver Jijie Shao
2025-06-12 2:13 ` [PATCH net-next 1/8] net: hns3: fix spelling mistake "reg_um" -> "reg_num" Jijie Shao
2025-06-12 2:13 ` [PATCH net-next 2/8] net: hns3: add the hns3_get_ae_dev() helper Jijie Shao
2025-06-12 11:16 ` Michal Swiatkowski [this message]
2025-06-12 12:21 ` Jijie Shao
2025-06-12 2:13 ` [PATCH net-next 3/8] net: hns3: add the hns3_get_ops() helper Jijie Shao
2025-06-12 11:21 ` Michal Swiatkowski
2025-06-12 12:30 ` Jijie Shao
2025-06-12 2:13 ` [PATCH net-next 4/8] net: hns3: add \n at the end when print msg Jijie Shao
2025-06-12 2:13 ` [PATCH net-next 5/8] net: hns3: set the freed pointers to NULL when lifetime is not end Jijie Shao
2025-06-12 2:13 ` [PATCH net-next 6/8] net: hns3: delete redundant address before the array Jijie Shao
2025-06-12 2:13 ` [PATCH net-next 7/8] net: hns3: add complete parentheses for some macros Jijie Shao
2025-06-12 2:13 ` [PATCH net-next 8/8] net: hns3: clear hns alarm: comparison of integer expressions of different signedness Jijie Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEq3DgCDh98Deidl@mev-dev.igk.intel.com \
--to=michal.swiatkowski@linux.intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=chenhao418@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=wangpeiyang1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox