From: Breno Leitao <leitao@debian.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
dw@davidwei.uk
Subject: Re: [PATCH net] net: drv: netdevsim: don't napi_complete() from netpoll
Date: Thu, 12 Jun 2025 01:53:13 -0700 [thread overview]
Message-ID: <aEqVefLEgSz9AzHG@gmail.com> (raw)
In-Reply-To: <20250611174643.2769263-1-kuba@kernel.org>
Hello Jakub,
On Wed, Jun 11, 2025 at 10:46:43AM -0700, Jakub Kicinski wrote:
> netdevsim supports netpoll. Make sure we don't call napi_complete()
> from it, since it may not be scheduled. Breno reports hitting a
> warning in napi_complete_done():
>
> WARNING: CPU: 14 PID: 104 at net/core/dev.c:6592 napi_complete_done+0x2cc/0x560
> __napi_poll+0x2d8/0x3a0
> handle_softirqs+0x1fe/0x710
>
> This is presumably after netpoll stole the SCHED bit prematurely.
>
> Reported-by: Breno Leitao <leitao@debian.org>
> Fixes: 3762ec05a9fb ("netdevsim: add NAPI support")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Tested-by: Breno Leitao <leitao@debian.org>
Thanks for the quick fix,
--breno
next prev parent reply other threads:[~2025-06-12 8:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 17:46 [PATCH net] net: drv: netdevsim: don't napi_complete() from netpoll Jakub Kicinski
2025-06-11 22:23 ` Dave Marquardt
2025-06-12 7:58 ` Breno Leitao
2025-06-12 13:11 ` Dave Marquardt
2025-06-12 8:53 ` Breno Leitao [this message]
2025-06-12 15:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEqVefLEgSz9AzHG@gmail.com \
--to=leitao@debian.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).