From: Joe Damato <joe@dama.to>
To: Florian Fainelli <florian.fainelli@broadcom.com>
Cc: netdev@vger.kernel.org, Justin Chen <justin.chen@broadcom.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"open list:BROADCOM ASP 2.0 ETHERNET DRIVER"
<bcm-kernel-feedback-list@broadcom.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v2 2/2] net: bcmasp: enable GRO software interrupt coalescing by default
Date: Thu, 12 Jun 2025 23:33:14 +0300 [thread overview]
Message-ID: <aEs5isPs68JAyjZq@MacBook-Air.local> (raw)
In-Reply-To: <20250611212730.252342-3-florian.fainelli@broadcom.com>
On Wed, Jun 11, 2025 at 02:27:30PM -0700, Florian Fainelli wrote:
> Utilize netdev_sw_irq_coalesce_default_on() to provide conservative
> default settings for GRO software interrupt coalescing.
>
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
> Reviewed-by: Justin Chen <justin.chen@broadcom.com>
> ---
> drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c b/drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c
> index 7dc28166d337..a6ea477bce3c 100644
> --- a/drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c
> +++ b/drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c
> @@ -1279,6 +1279,8 @@ struct bcmasp_intf *bcmasp_interface_create(struct bcmasp_priv *priv,
> ndev->hw_features |= ndev->features;
> ndev->needed_headroom += sizeof(struct bcmasp_pkt_offload);
>
> + netdev_sw_irq_coalesce_default_on(ndev);
> +
> return intf;
Just to make it explicit to other readers: netdev_sw_irq_coalesce_default_on
appears to be called before register_netdev, as the documentation for
netdev_sw_irq_coalesce_default_on describes.
Reviewed-by: Joe Damato <joe@dama.to>
next prev parent reply other threads:[~2025-06-12 20:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 21:27 [PATCH net-next v2 0/2] net: bcmasp: add support for GRO Florian Fainelli
2025-06-11 21:27 ` [PATCH net-next v2 1/2] net: bcmasp: Utilize napi_complete_done() return value Florian Fainelli
2025-06-12 20:22 ` Joe Damato
2025-06-11 21:27 ` [PATCH net-next v2 2/2] net: bcmasp: enable GRO software interrupt coalescing by default Florian Fainelli
2025-06-12 20:33 ` Joe Damato [this message]
2025-06-13 1:30 ` [PATCH net-next v2 0/2] net: bcmasp: add support for GRO patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEs5isPs68JAyjZq@MacBook-Air.local \
--to=joe@dama.to \
--cc=andrew+netdev@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=justin.chen@broadcom.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).