Re: [PATCH net-next 4/9] net: ethtool: add dedicated callbacks for getting and setting rxfh fields

Jakub Kicinski
2025-06-13T14:39:28Z

On Fri, 13 Jun 2025 08:36:15 +0300 Joe Damato wrote:
> > @@ -1492,7 +1527,7 @@ static noinline_for_stack int ethtool_set_rxfh(struct net_device *dev,
> > u8 *rss_config;
> > int ret;
> >
> > - if (!ops->get_rxnfc || !ops->set_rxfh)
> > + if ((!ops->get_rxnfc && !ops->get_rxfh_fields) || !ops->set_rxfh)
> > return -EOPNOTSUPP;
>
> I realize I am late to the thread, but is this part above correct? It seems
> like ethtool_set_rxfh calls ops->get_rxnfc but not ops->get_rxfh_fields,
> unless I missed something in an earlier patch?

It calls ethtool_check_flow_types(), but you're right it also calls
->get_rxnfc, so it should have been an ||. I'll correct in the "closing
patch" that removes the calls to get_rxnfc once all drivers are done.
Thanks!