Re: [PATCH net-next 1/9] net: ethtool: copy the rxfh flow handling

Joe Damato
2025-06-12T21:02:51Z

On Wed, Jun 11, 2025 at 07:59:41AM -0700, Jakub Kicinski wrote:
> RX Flow Hash configuration uses the same argument structure
> as flow filters. This is probably why ethtool IOCTL handles
> them together. The more checks we add the more convoluted
> this code is getting (as some of the checks apply only
> to flow filters and others only to the hashing).
>
> Copy the code to separate the handling. This is an exact
> copy, the next change will remove unnecessary handling.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: andrew@lunn.ch
> CC: ecree.xilinx@gmail.com
> ---
> net/ethtool/ioctl.c | 93 ++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 92 insertions(+), 1 deletion(-)
>

Reviewed-by: Joe Damato <joe@dama.to>