From: Subbaraya Sundeep <sbhatta@marvell.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Jun Miao <jun.miao@intel.com>, <oneukum@suse.com>,
<netdev@vger.kernel.org>, <linux-usb@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] net: usb: Convert tasklet API to new bottom half workqueue mechanism
Date: Fri, 13 Jun 2025 09:16:25 +0000 [thread overview]
Message-ID: <aEvsaUrhXgFzvtzZ@b9e1f7b84bd3> (raw)
In-Reply-To: <20250612185131.2dc7218a@kernel.org>
On 2025-06-13 at 01:51:31, Jakub Kicinski (kuba@kernel.org) wrote:
> On Tue, 10 Jun 2025 22:54:03 +0800 Jun Miao wrote:
> > - if (rx_alloc_submit(dev, GFP_ATOMIC) == -ENOLINK)
> > + if (rx_alloc_submit(dev, GFP_NOIO) == -ENOLINK)
>
> Sorry, I think Subbaraya mislead you. v1 was fine.
> If we want to change the flags (which Im not sure is correct) it should
> be a separate commit. Could you repost v1? There is no need to attribute
Yeah hence asked to correct me if wrong.
GFP_ATOMIC has to be there - "this patchset implements BH workqueues
which are like regular workqueues but executes work items in the BH
(softirq) context" from:
https://lwn.net/Articles/960020/
Thanks,
Sundeep
> reviewers with Suggested-by tags. They can send their review tags if
> they so wish.
> --
> pw-bot: cr
next prev parent reply other threads:[~2025-06-13 9:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 14:54 [PATCH V2] net: usb: Convert tasklet API to new bottom half workqueue mechanism Jun Miao
2025-06-13 1:51 ` Jakub Kicinski
2025-06-13 9:16 ` Subbaraya Sundeep [this message]
2025-06-13 12:33 ` Miao, Jun
-- strict thread matches above, loose matches on Subject: below --
2025-06-14 11:14 [PATCH v2] " Jun Miao
2025-06-14 14:15 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEvsaUrhXgFzvtzZ@b9e1f7b84bd3 \
--to=sbhatta@marvell.com \
--cc=jun.miao@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).