From: Joe Damato <joe@dama.to>
To: Alok Tiwari <alok.a.tiwari@oracle.com>
Cc: pabeni@redhat.com, kuba@kernel.org, jeroendb@google.com,
hramamurthy@google.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, netdev@vger.kernel.org,
almasrymina@google.com, bcf@google.com,
linux-kernel@vger.kernel.org, ziweixiao@google.com,
joshwash@google.com, willemb@google.com, pkaligineedi@google.com
Subject: Re: [PATCH 1/2] gve: Fix various typos and improve code comments
Date: Mon, 16 Jun 2025 18:49:59 +0300 [thread overview]
Message-ID: <aFA9J6-6Kj3LcQL8@MacBook-Air.local> (raw)
In-Reply-To: <20250616054504.1644770-1-alok.a.tiwari@oracle.com>
On Sun, Jun 15, 2025 at 10:45:00PM -0700, Alok Tiwari wrote:
> - Correct spelling and improves the clarity of comments
> "confiugration" -> "configuration"
> "spilt" -> "split"
> "It if is 0" -> "If it is 0"
> "DQ" -> "DQO" (correct abbreviation)
> - Clarify BIT(0) flag usage in gve_get_priv_flags()
> - Replaced hardcoded array size with GVE_NUM_PTYPES
> for clarity and maintainability.
Subject line should target the tree ("net-next") and it's helpful to include
the base-commit (git format-patch --base=auto). Since this series is two
patches you should probably include a short cover letter.
That said, the changes seem reasonable so when you resubmit you can add my:
Reviewed-by: Joe Damato <joe@dama.to>
next prev parent reply other threads:[~2025-06-16 15:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-16 5:45 [PATCH 1/2] gve: Fix various typos and improve code comments Alok Tiwari
2025-06-16 5:45 ` [PATCH 2/2] gve: Return error for unknown admin queue command Alok Tiwari
2025-06-16 15:49 ` Joe Damato [this message]
2025-06-16 23:25 ` [PATCH 1/2] gve: Fix various typos and improve code comments Mina Almasry
2025-06-18 1:41 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFA9J6-6Kj3LcQL8@MacBook-Air.local \
--to=joe@dama.to \
--cc=almasrymina@google.com \
--cc=alok.a.tiwari@oracle.com \
--cc=andrew+netdev@lunn.ch \
--cc=bcf@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hramamurthy@google.com \
--cc=jeroendb@google.com \
--cc=joshwash@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pkaligineedi@google.com \
--cc=willemb@google.com \
--cc=ziweixiao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).