From: Stanislav Fomichev <stfomichev@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
andrew@lunn.ch, donald.hunter@gmail.com,
kory.maincent@bootlin.com, sdf@fomichev.me
Subject: Re: [PATCH net] net: ethtool: remove duplicate defines for family info
Date: Tue, 17 Jun 2025 13:48:29 -0700 [thread overview]
Message-ID: <aFHUnZlqSHShA2sN@mini-arch> (raw)
In-Reply-To: <20250617202240.811179-1-kuba@kernel.org>
On 06/17, Jakub Kicinski wrote:
> Commit under fixes switched to uAPI generation from the YAML
> spec. A number of custom defines were left behind, mostly
> for commands very hard to express in YAML spec.
>
> Among what was left behind was the name and version of
> the generic netlink family. Problem is that the codegen
> always outputs those values so we ended up with a duplicated,
> differently named set of defines.
>
> Provide naming info in YAML and remove the incorrect defines.
>
> Fixes: 8d0580c6ebdd ("ethtool: regenerate uapi header from the spec")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Acked-by: Stanislav Fomichev <sdf@fomichev.me>
next prev parent reply other threads:[~2025-06-17 20:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 20:22 [PATCH net] net: ethtool: remove duplicate defines for family info Jakub Kicinski
2025-06-17 20:48 ` Stanislav Fomichev [this message]
2025-06-18 21:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFHUnZlqSHShA2sN@mini-arch \
--to=stfomichev@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).