From: Stanislav Fomichev <stfomichev@gmail.com>
To: Jason Xing <kerneljasonxing@gmail.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, bjorn@kernel.org, magnus.karlsson@intel.com,
maciej.fijalkowski@intel.com, jonathan.lemon@gmail.com,
sdf@fomichev.me, ast@kernel.org, daniel@iogearbox.net,
hawk@kernel.org, john.fastabend@gmail.com, joe@dama.to,
bpf@vger.kernel.org, netdev@vger.kernel.org,
Jason Xing <kernelxing@tencent.com>
Subject: Re: [PATCH net-next v2] net: xsk: add sysctl_xsk_max_tx_budget in the xmit path
Date: Wed, 18 Jun 2025 08:09:26 -0700 [thread overview]
Message-ID: <aFLWpssHj9sE9vvc@mini-arch> (raw)
In-Reply-To: <20250618065553.96822-1-kerneljasonxing@gmail.com>
On 06/18, Jason Xing wrote:
> From: Jason Xing <kernelxing@tencent.com>
>
> For some applications, it's quite useful to let users have the chance to
> tune the max budget, like accelerating transmission, when xsk is sending
> packets. Exposing such a knob also helps auto/AI tuning in the long run.
>
> The patch unifies two definitions into one that is 32 by default and
> makes the sysctl knob namespecified.
>
> Signed-off-by: Jason Xing <kernelxing@tencent.com>
> ---
> v2
> Link: https://lore.kernel.org/all/20250617002236.30557-1-kerneljasonxing@gmail.com/
> 1. use a per-netns sysctl knob
Why are you still insisting on the sysctl? Why not a per-socket (struct
xdp_sock) value? And then you can add a setsockopt (xsk_setsockopt) to tune it.
next prev parent reply other threads:[~2025-06-18 15:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-18 6:55 [PATCH net-next v2] net: xsk: add sysctl_xsk_max_tx_budget in the xmit path Jason Xing
2025-06-18 15:09 ` Stanislav Fomichev [this message]
2025-06-18 19:21 ` Jason Xing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFLWpssHj9sE9vvc@mini-arch \
--to=stfomichev@gmail.com \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=joe@dama.to \
--cc=john.fastabend@gmail.com \
--cc=jonathan.lemon@gmail.com \
--cc=kerneljasonxing@gmail.com \
--cc=kernelxing@tencent.com \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox