From: Florian Westphal <fw@strlen.de>
To: Eric Woudstra <ericwouds@gmail.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>,
Nikolay Aleksandrov <razor@blackwall.org>,
Vladimir Oltean <olteanv@gmail.com>,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [RFC PATCH v2 nf-next] selftests: netfilter: Add bridge_fastpath.sh
Date: Mon, 23 Jun 2025 15:14:28 +0200 [thread overview]
Message-ID: <aFlTNAsZh-g1SvWQ@strlen.de> (raw)
In-Reply-To: <20250617065930.23647-1-ericwouds@gmail.com>
Eric Woudstra <ericwouds@gmail.com> wrote:
> Without patches:
>
> PASS: unaware bridge, without encaps, without fastpath
> PASS: unaware bridge, with single vlan encap, without fastpath
> ERROR: unaware bridge, with double q vlan encaps, without fastpath: ipv4/6: established bytes 0 < 4194304
> ERROR: unaware bridge, with 802.1ad vlan encaps, without fastpath: ipv4/6: established bytes 0 < 4194304
> PASS: aware bridge, without/without vlan encap, without fastpath
> PASS: aware bridge, with/without vlan encap, without fastpath
> PASS: aware bridge, with/with vlan encap, without fastpath
> PASS: aware bridge, without/with vlan encap, without fastpath
> PASS: forward, without vlan-device, without vlan encap, client1, without fastpath
> PASS: forward, without vlan-device, without vlan encap, client1, with fastpath
> PASS: forward, without vlan-device, with vlan encap, client1, without fastpath
> ERROR: forward, without vlan-device, with vlan encap, client1, with fastpath: ipv4/6: tcp broken
> PASS: forward, with vlan-device, with vlan encap, client1, without fastpath
> PASS: forward, with vlan-device, with vlan encap, client1, with fastpath
> PASS: forward, with vlan-device, without vlan encap, client1, without fastpath
> PASS: forward, with vlan-device, without vlan encap, client1, with fastpath
> ERROR: bridge fastpath test has failed
Would you mind sending a version without RFC tag that passes
without any of the patches?
I'll leave it up to you if you prefer to remove the subtests
that don't work without your changes or downgrade them to
a SKIP or similar.
That way, at least this patch could be applied. And I think we
can all agree that it would be good to have it in-tree.
prev parent reply other threads:[~2025-06-23 13:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 6:59 [RFC PATCH v2 nf-next] selftests: netfilter: Add bridge_fastpath.sh Eric Woudstra
2025-06-17 11:34 ` Simon Horman
2025-06-23 13:14 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFlTNAsZh-g1SvWQ@strlen.de \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ericwouds@gmail.com \
--cc=horms@kernel.org \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=razor@blackwall.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).