From: Ido Schimmel <idosch@nvidia.com>
To: Fabian Pfitzner <f.pfitzner@pengutronix.de>
Cc: netdev@vger.kernel.org, dsahern@gmail.com,
bridge@lists.linux-foundation.org, entwicklung@pengutronix.de,
razor@blackwall.org
Subject: Re: [PATCH iproute2-next v5 1/3] bridge: move mcast querier dumping code into a shared function
Date: Tue, 24 Jun 2025 14:55:34 +0300 [thread overview]
Message-ID: <aFqSNpyVFt85XJbm@shredder> (raw)
In-Reply-To: <20250623093316.1215970-2-f.pfitzner@pengutronix.de>
On Mon, Jun 23, 2025 at 11:33:16AM +0200, Fabian Pfitzner wrote:
> Put mcast querier dumping code into a shared function. This function
> will be called from the bridge utility in a later patch.
>
> Adapt the code such that the vtb parameter is used
> instead of tb[IFLA_BR_MCAST_QUERIER_STATE].
>
> Signed-off-by: Fabian Pfitzner <f.pfitzner@pengutronix.de>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
[...]
> +void bridge_print_mcast_querier_state(const struct rtattr *vtb)
> +{
> + struct rtattr *bqtb[BRIDGE_QUERIER_MAX + 1];
> +
I assume you added the blank line because of checkpatch, but I think
it's wrong in this case.
> + SPRINT_BUF(other_time);
> +
> + parse_rtattr_nested(bqtb, BRIDGE_QUERIER_MAX, vtb);
> + memset(other_time, 0, sizeof(other_time));
next prev parent reply other threads:[~2025-06-24 11:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 9:33 [PATCH iproute2-next v5 0/3] bridge: dump mcast querier state per vlan Fabian Pfitzner
2025-06-23 9:33 ` [PATCH iproute2-next v5 1/3] bridge: move mcast querier dumping code into a shared function Fabian Pfitzner
2025-06-24 11:55 ` Ido Schimmel [this message]
2025-06-24 12:40 ` Nikolay Aleksandrov
2025-06-23 9:33 ` [PATCH iproute2-next v5 2/3] bridge: dump mcast querier per vlan Fabian Pfitzner
2025-06-24 11:57 ` Ido Schimmel
2025-06-24 12:40 ` Nikolay Aleksandrov
2025-06-23 9:33 ` [PATCH iproute2-next v5 3/3] bridge: refactor bridge mcast querier function Fabian Pfitzner
2025-06-24 12:01 ` Ido Schimmel
2025-06-24 12:41 ` Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFqSNpyVFt85XJbm@shredder \
--to=idosch@nvidia.com \
--cc=bridge@lists.linux-foundation.org \
--cc=dsahern@gmail.com \
--cc=entwicklung@pengutronix.de \
--cc=f.pfitzner@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).