From: Seth Forshee <sforshee@kernel.org>
To: Jay Vosburgh <jv@jvosburgh.net>
Cc: Tonghao Zhang <tonghao@bamaicloud.com>,
carlos.bilbao@kernel.org, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, bilbao@vt.edu
Subject: Re: [PATCH] bonding: Improve the accuracy of LACPDU transmissions
Date: Wed, 25 Jun 2025 11:06:32 -0500 [thread overview]
Message-ID: <aFweiFJHj-3c3Zv9@do-x1carbon> (raw)
In-Reply-To: <aFsq8QSZRNAE8PYs@do-x1carbon>
On Tue, Jun 24, 2025 at 05:47:13PM -0500, Seth Forshee wrote:
> As I understand it the intention is to ensure that LACPDU tx is spaced
> out by at least ~300ms, not to align them to an arbitrary ~300ms
> boundary. If so, a simple improvement would be to reset the counter only
> when an LACPDU is sent, then allow sending a LACPDU any time after it
> reaches zero. Though I still think it makes sense to make the state
> machines time-based rather than counter-based to ensure they aren't
> sensitive to delays in running the delayed work.
Sent a patch which only changes when the counter is reset:
https://lore.kernel.org/all/20250625-fix-lacpdu-jitter-v1-1-4d0ee627e1ba@kernel.org/
On an unloaded system the timing of LACPDUs is consistent within ~10ms
after this change.
prev parent reply other threads:[~2025-06-25 16:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-18 19:53 [PATCH] bonding: Improve the accuracy of LACPDU transmissions carlos.bilbao
2025-06-20 3:15 ` Tonghao Zhang
2025-06-24 21:15 ` Jay Vosburgh
2025-06-24 22:27 ` Carlos Bilbao
2025-06-24 22:33 ` Carlos Bilbao
2025-06-24 22:47 ` Seth Forshee
2025-06-25 16:06 ` Seth Forshee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFweiFJHj-3c3Zv9@do-x1carbon \
--to=sforshee@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=bilbao@vt.edu \
--cc=carlos.bilbao@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jv@jvosburgh.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tonghao@bamaicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox