From: Stanislav Fomichev <stfomichev@gmail.com>
To: Jordan Rife <jordan@jrife.io>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <martin.lau@linux.dev>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Kuniyuki Iwashima <kuniyu@google.com>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>
Subject: Re: [PATCH v3 bpf-next 08/12] selftests/bpf: Allow for iteration over multiple states
Date: Mon, 30 Jun 2025 11:34:09 -0700 [thread overview]
Message-ID: <aGLYoSIEWtmWieLM@mini-arch> (raw)
In-Reply-To: <20250630171709.113813-9-jordan@jrife.io>
On 06/30, Jordan Rife wrote:
> Add parentheses around loopback address check to fix up logic and make
> the socket state filter configurable for the TCP socket iterators.
> Iterators can skip the socket state check by setting ss to 0.
>
> Signed-off-by: Jordan Rife <jordan@jrife.io>
> ---
> .../selftests/bpf/prog_tests/sock_iter_batch.c | 2 ++
> tools/testing/selftests/bpf/progs/sock_iter_batch.c | 11 ++++++-----
> 2 files changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/sock_iter_batch.c b/tools/testing/selftests/bpf/prog_tests/sock_iter_batch.c
> index 0d0f1b4debff..afe0f55ead75 100644
> --- a/tools/testing/selftests/bpf/prog_tests/sock_iter_batch.c
> +++ b/tools/testing/selftests/bpf/prog_tests/sock_iter_batch.c
> @@ -433,6 +433,7 @@ static void do_resume_test(struct test_case *tc)
> skel->rodata->ports[0] = 0;
> skel->rodata->ports[1] = 0;
> skel->rodata->sf = tc->family;
> + skel->rodata->ss = 0;
>
> err = sock_iter_batch__load(skel);
> if (!ASSERT_OK(err, "sock_iter_batch__load"))
> @@ -498,6 +499,7 @@ static void do_test(int sock_type, bool onebyone)
> skel->rodata->ports[i] = ntohs(local_port);
> }
> skel->rodata->sf = AF_INET6;
[..]
> + skel->rodata->ss = TCP_LISTEN;
nit: let's maybe add `if (sock_type == SOCK_STREAM)` here? I see that you're
adding ss check only to the tcp prog, but let's also clearly state
the intent here..
next prev parent reply other threads:[~2025-06-30 18:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-30 17:16 [PATCH v3 bpf-next 00/12] bpf: tcp: Exactly-once socket iteration Jordan Rife
2025-06-30 17:16 ` [PATCH v3 bpf-next 01/12] bpf: tcp: Make mem flags configurable through bpf_iter_tcp_realloc_batch Jordan Rife
2025-06-30 17:16 ` [PATCH v3 bpf-next 02/12] bpf: tcp: Make sure iter->batch always contains a full bucket snapshot Jordan Rife
2025-06-30 18:31 ` Stanislav Fomichev
2025-06-30 17:16 ` [PATCH v3 bpf-next 03/12] bpf: tcp: Get rid of st_bucket_done Jordan Rife
2025-06-30 17:16 ` [PATCH v3 bpf-next 04/12] bpf: tcp: Use bpf_tcp_iter_batch_item for bpf_tcp_iter_state batch items Jordan Rife
2025-06-30 17:16 ` [PATCH v3 bpf-next 05/12] bpf: tcp: Avoid socket skips and repeats during iteration Jordan Rife
2025-06-30 18:32 ` Stanislav Fomichev
2025-07-06 18:36 ` Jordan Rife
2025-06-30 17:16 ` [PATCH v3 bpf-next 06/12] selftests/bpf: Add tests for bucket resume logic in listening sockets Jordan Rife
2025-06-30 17:17 ` [PATCH v3 bpf-next 07/12] selftests/bpf: Allow for iteration over multiple ports Jordan Rife
2025-06-30 17:17 ` [PATCH v3 bpf-next 08/12] selftests/bpf: Allow for iteration over multiple states Jordan Rife
2025-06-30 18:34 ` Stanislav Fomichev [this message]
2025-06-30 17:17 ` [PATCH v3 bpf-next 09/12] selftests/bpf: Make ehash buckets configurable in socket iterator tests Jordan Rife
2025-06-30 17:17 ` [PATCH v3 bpf-next 10/12] selftests/bpf: Create established sockets " Jordan Rife
2025-06-30 18:47 ` Stanislav Fomichev
2025-06-30 17:17 ` [PATCH v3 bpf-next 11/12] selftests/bpf: Create iter_tcp_destroy test program Jordan Rife
2025-06-30 17:17 ` [PATCH v3 bpf-next 12/12] selftests/bpf: Add tests for bucket resume logic in established sockets Jordan Rife
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGLYoSIEWtmWieLM@mini-arch \
--to=stfomichev@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jordan@jrife.io \
--cc=kuniyu@google.com \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).