From: Guillaume Nault <gnault@redhat.com>
To: Ido Schimmel <idosch@idosch.org>, Aiden Yang <ling@moedove.com>
Cc: netdev@vger.kernel.org, kuba@kernel.org, pabeni@redhat.com,
davem@davemloft.net, MoeDove NOC <noc@moedove.com>
Subject: Re: [BUG] net: gre: IPv6 link-local multicast is silently dropped (Regression)
Date: Wed, 2 Jul 2025 12:12:22 +0200 [thread overview]
Message-ID: <aGUGBjVZZPBWcRlA@debian> (raw)
In-Reply-To: <aGO0whOGhE4LmVo2@shredder>
On Tue, Jul 01, 2025 at 01:13:22PM +0300, Ido Schimmel wrote:
> Makes sense. So you will submit it to net and extend gre_ipv6_lladdr.sh
> to test for the presence of a multicast route?
Yes. I'd just like to have a confirmation from Aiden first.
Aiden, can you confirm that the following patch fixes the issue on your
side?
---- >8 ----
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index ba2ec7c870cc..870a0bd6c2ba 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -3525,11 +3525,9 @@ static void addrconf_gre_config(struct net_device *dev)
ASSERT_RTNL();
- idev = ipv6_find_idev(dev);
- if (IS_ERR(idev)) {
- pr_debug("%s: add_dev failed\n", __func__);
+ idev = addrconf_add_dev(dev);
+ if (IS_ERR(idev))
return;
- }
/* Generate the IPv6 link-local address using addrconf_addr_gen(),
* unless we have an IPv4 GRE device not bound to an IP address and
@@ -3543,9 +3541,6 @@ static void addrconf_gre_config(struct net_device *dev)
}
add_v4_addrs(idev);
-
- if (dev->flags & IFF_POINTOPOINT)
- addrconf_add_mroute(dev);
}
#endif
next prev parent reply other threads:[~2025-07-02 10:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-29 6:40 [BUG] net: gre: IPv6 link-local multicast is silently dropped (Regression) Aiden Yang
2025-06-29 14:49 ` Ido Schimmel
2025-06-30 11:54 ` Guillaume Nault
2025-07-01 10:13 ` Ido Schimmel
2025-07-02 10:12 ` Guillaume Nault [this message]
2025-07-06 15:40 ` Gary Guo
2025-07-09 14:15 ` Guillaume Nault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGUGBjVZZPBWcRlA@debian \
--to=gnault@redhat.com \
--cc=davem@davemloft.net \
--cc=idosch@idosch.org \
--cc=kuba@kernel.org \
--cc=ling@moedove.com \
--cc=netdev@vger.kernel.org \
--cc=noc@moedove.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox