Re: [PATCH net 2/3] ovpn: explicitly reject netlink attr PEER_LOCAL_PORT in CMD_PEER_NEW/SET

Jakub Kicinski
2025-07-14T14:56:45Z

On Sun, 13 Jul 2025 22:04:49 +0200 Antonio Quartulli wrote:
> On 08/07/2025 16:47, Jakub Kicinski wrote:
> > In any case. I think what I suggested is slightly better than
> > opencoding, even if verbose :) So I set the patches to Changes
> > Requested..
>
> So you'd want to go with what you suggested on July 7th?
> I.e. using subset-of and defining 'peer-input'/'ovpn-peer-input'.
> Did I get it right?

Yes, please. It will improve the generated userspace C code, too.

> As Sabrina pointed out, I'll also define a subset for PEER_DEL/GET,
> where we only need the PEER_ID.

GET may be hard but you can try.