From: Cong Wang <xiyou.wangcong@gmail.com>
To: Lizhi Xu <lizhi.xu@windriver.com>
Cc: davem@davemloft.net, edumazet@google.com, horms@kernel.org,
jhs@mojatatu.com, jiri@resnulli.us, kuba@kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
pabeni@redhat.com, syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH V2] net/sched: Prevent notify to parent who unsupport class ops
Date: Fri, 4 Jul 2025 22:07:34 -0700 [thread overview]
Message-ID: <aGizFhZwnPo98Bj/@pop-os.localdomain> (raw)
In-Reply-To: <20250705011823.1443446-1-lizhi.xu@windriver.com>
Hi Lizhi,
On Sat, Jul 05, 2025 at 09:18:22AM +0800, Lizhi Xu wrote:
> If the parent qdisc does not support class operations then exit notify.
>
> In addition, the validity of the cl value is judged before executing the
> notify. Similarly, the notify is exited when the address represented by
> its value is invalid.
>
> Reported-by: syzbot+1261670bbdefc5485a06@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=1261670bbdefc5485a06
Maybe I didn't make it clear, I think Victor's patch also fixes this
bug.
https://lore.kernel.org/netdev/20250704163422.160424-1-victor@mojatatu.com/
Can you check if you still see the crash with his fix?
The reason why I am asking is because his fix addresses a problem
earlier on the code path, which possibly makes your fix unnecessary.
Hence, his fix is closer to the root cause.
Please test and confirm.
Thanks!
next prev parent reply other threads:[~2025-07-05 5:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-04 5:20 [syzbot] [net?] general protection fault in qdisc_tree_reduce_backlog syzbot
2025-07-04 8:04 ` [PATCH] net/sched: Prevent notify to parent who unsupport class ops Lizhi Xu
2025-07-04 14:01 ` Paolo Abeni
2025-07-05 0:03 ` Cong Wang
2025-07-05 1:18 ` [PATCH V2] " Lizhi Xu
2025-07-05 5:07 ` Cong Wang [this message]
2025-07-05 13:59 ` Jamal Hadi Salim
2025-07-04 8:34 ` [syzbot] [net?] general protection fault in qdisc_tree_reduce_backlog syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGizFhZwnPo98Bj/@pop-os.localdomain \
--to=xiyou.wangcong@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizhi.xu@windriver.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox