From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Jijie Shao <shaojijie@huawei.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
Frank.Sae@motor-comm.com, hkallweit1@gmail.com,
shenjian15@huawei.com, liuyonglong@huawei.com,
chenhao418@huawei.com, jonathan.cameron@huawei.com,
shameerali.kolothum.thodi@huawei.com, salil.mehta@huawei.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] net: hibmcge: Add support for PHY LEDs on YT8521
Date: Wed, 16 Jul 2025 11:53:53 +0100 [thread overview]
Message-ID: <aHeEwZaqUd0kNdUQ@shell.armlinux.org.uk> (raw)
In-Reply-To: <20250716100041.2833168-3-shaojijie@huawei.com>
On Wed, Jul 16, 2025 at 06:00:41PM +0800, Jijie Shao wrote:
> hibmcge is a PCIE EP device, and its controller is
> not on the board. And board uses ACPI not DTS
> to create the device tree.
>
> So, this makes it impossible to add a "reg" property(used in of_phy_led())
> for hibmcge. Therefore, the PHY_LED framework cannot be used directly.
It would be better to find a way to solve this problem, rather than
we end up with every ethernet driver having its own LED code. Each
driver having its own LED code simply won't scale for over-worked
kernel maintainers.
Sorry, but NAK.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-07-16 10:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 10:00 [PATCH net-next 0/2] net: hibmcge: Add support for PHY LEDs on YT8521 Jijie Shao
2025-07-16 10:00 ` [PATCH net-next 1/2] net: phy: motorcomm: " Jijie Shao
2025-07-16 16:39 ` Andrew Lunn
2025-08-07 9:50 ` Heiko Stübner
2025-08-11 13:16 ` Jijie Shao
2025-08-11 15:01 ` Russell King (Oracle)
2025-08-12 13:13 ` Jijie Shao
2025-07-16 10:00 ` [PATCH net-next 2/2] net: hibmcge: " Jijie Shao
2025-07-16 10:53 ` Russell King (Oracle) [this message]
2025-07-16 16:42 ` Andrew Lunn
2025-07-17 8:39 ` Jijie Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHeEwZaqUd0kNdUQ@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=Frank.Sae@motor-comm.com \
--cc=andrew+netdev@lunn.ch \
--cc=chenhao418@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).