From: Ido Schimmel <idosch@nvidia.com>
To: Richard Gobert <richardbgobert@gmail.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org, dsahern@kernel.org,
razor@blackwall.org, petrm@nvidia.com, menglong8.dong@gmail.com,
daniel@iogearbox.net, martin.lau@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v4 0/4] net: add local address bind support to vxlan and geneve
Date: Sun, 20 Jul 2025 17:00:03 +0300 [thread overview]
Message-ID: <aHz2Y6Be3G4_P7ZM@shredder> (raw)
In-Reply-To: <20250717115412.11424-1-richardbgobert@gmail.com>
On Thu, Jul 17, 2025 at 01:54:08PM +0200, Richard Gobert wrote:
> This series adds local address bind support to both vxlan
> and geneve sockets.
A few comments:
1. Binding the VXLAN socket to the local address does break
functionality. Run the VXLAN selftests in tools/testing/selftests/net/
and you will see failures. IOW, you cannot change the default behavior.
You might not need the first patch if the new behavior is opt-in rather
than opt-out.
2. Please add a selftest for the new functionality. See the existing
VXLAN selftests for reference. There is no need to wait for the iproute2
patch to be accepted. You can have a check to skip the test if iproute2
does not have the required functionality.
3. The cover letter should explain the motivation for these patches.
Currently it only explains what the patches do.
next prev parent reply other threads:[~2025-07-20 14:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-17 11:54 [PATCH net-next v4 0/4] net: add local address bind support to vxlan and geneve Richard Gobert
2025-07-17 11:54 ` [PATCH net-next v4 1/4] net: udp: add freebind option to udp_sock_create Richard Gobert
2025-07-17 11:54 ` [PATCH net-next v4 2/4] net: vxlan: add netlink option to bind vxlan sockets to local addresses Richard Gobert
2025-07-18 7:35 ` Simon Horman
2025-07-20 14:10 ` Ido Schimmel
2025-07-17 11:54 ` [PATCH net-next v4 3/4] net: vxlan: bind vxlan sockets to their local address Richard Gobert
2025-07-17 11:54 ` [PATCH net-next v4 4/4] net: geneve: enable binding geneve sockets to local addresses Richard Gobert
2025-07-18 7:31 ` Simon Horman
2025-07-18 8:26 ` Simon Horman
2025-07-18 9:00 ` kernel test robot
2025-07-20 14:16 ` Ido Schimmel
2025-07-20 14:00 ` Ido Schimmel [this message]
2025-07-31 12:05 ` [PATCH net-next v4 0/4] net: add local address bind support to vxlan and geneve Richard Gobert
2025-07-31 13:07 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHz2Y6Be3G4_P7ZM@shredder \
--to=idosch@nvidia.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@kernel.org \
--cc=menglong8.dong@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=razor@blackwall.org \
--cc=richardbgobert@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).