From: Cong Wang <xiyou.wangcong@gmail.com>
To: William Liu <will@willsroot.io>
Cc: netdev@vger.kernel.org, jhs@mojatatu.com, pabeni@redhat.com,
kuba@kernel.org, jiri@resnulli.us, davem@davemloft.net,
edumazet@google.com, horms@kernel.org, savy@syst3mfailure.io,
victor@mojatatu.com
Subject: Re: [PATCH net v4 2/2] selftests/tc-testing: Check backlog stats in gso_skb case
Date: Wed, 30 Jul 2025 10:54:22 -0700 [thread overview]
Message-ID: <aIpcTv4ayyP+ya25@pop-os.localdomain> (raw)
In-Reply-To: <20250727235642.216527-1-will@willsroot.io>
On Sun, Jul 27, 2025 at 11:57:10PM +0000, William Liu wrote:
> + "setup": [
> + "$IP link set dev $DUMMY up || true",
> + "$IP addr add 10.10.11.10/24 dev $DUMMY || true",
> + "$TC qdisc add dev $DUMMY root handle 1: tbf rate 8bit burst 100b latency 100ms",
> + "$TC qdisc replace dev $DUMMY handle 2: parent 1:1 hhf limit 1000",
> + [
> + "ping -I $DUMMY -c2 10.10.11.11",
> + 1
> + ],
Sorry, I still have troubles understanding the magic "1" here, and I
don't find any other selftest using it. So why do we need it here?
You said it is in the original reproducer, but the original reproducer
is not part of tc-testing. This does not explain to me.
Thanks.
next prev parent reply other threads:[~2025-07-30 17:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-27 23:56 [PATCH net v4 1/2] net/sched: Fix backlog accounting in qdisc_dequeue_internal William Liu
2025-07-27 23:57 ` [PATCH net v4 2/2] selftests/tc-testing: Check backlog stats in gso_skb case William Liu
2025-07-30 17:54 ` Cong Wang [this message]
2025-07-30 17:59 ` William Liu
2025-08-08 21:27 ` [PATCH net v4 1/2] net/sched: Fix backlog accounting in qdisc_dequeue_internal Jakub Kicinski
2025-08-10 21:06 ` William Liu
2025-08-11 15:29 ` Jakub Kicinski
2025-08-11 16:52 ` William Liu
2025-08-11 17:24 ` Jakub Kicinski
2025-08-11 17:51 ` William Liu
2025-08-12 0:51 ` Jakub Kicinski
2025-08-12 2:10 ` William Liu
2025-08-12 14:38 ` Jakub Kicinski
2025-08-12 16:59 ` William Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aIpcTv4ayyP+ya25@pop-os.localdomain \
--to=xiyou.wangcong@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=savy@syst3mfailure.io \
--cc=victor@mojatatu.com \
--cc=will@willsroot.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).