From: Stanislav Fomichev <stfomichev@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
Duo Yi <duo@meta.com>,
andrew@lunn.ch, donald.hunter@gmail.com,
kory.maincent@bootlin.com, sdf@fomichev.me
Subject: Re: [PATCH net] netlink: specs: ethtool: fix module EEPROM input/output arguments
Date: Wed, 30 Jul 2025 14:40:50 -0700 [thread overview]
Message-ID: <aIqRYhDPduCdGQjB@mini-arch> (raw)
In-Reply-To: <20250730172137.1322351-1-kuba@kernel.org>
On 07/30, Jakub Kicinski wrote:
> Module (SFP) eeprom GET has a lot of input params, they are all
> mistakenly listed as output in the spec. Looks like kernel doesn't
> output them at all. Correct what are the inputs and what the outputs.
>
> Reported-by: Duo Yi <duo@meta.com>
> Fixes: a353318ebf24 ("tools: ynl: populate most of the ethtool spec")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Acked-by: Stanislav Fomichev <sdf@fomichev.me>
(seems to match what eeprom_parse_request and eeprom_fill_reply are
doing)
next prev parent reply other threads:[~2025-07-30 21:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-30 17:21 [PATCH net] netlink: specs: ethtool: fix module EEPROM input/output arguments Jakub Kicinski
2025-07-30 21:40 ` Stanislav Fomichev [this message]
2025-07-31 18:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aIqRYhDPduCdGQjB@mini-arch \
--to=stfomichev@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=duo@meta.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).