From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 736E31EEA54 for ; Thu, 7 Aug 2025 05:36:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754544998; cv=none; b=HlAxTmLS0MRT6qy889VlY3Jg4wxVhij//KgBWuzc0MuR0RrGZ1ek12l/cb5fLLoit9ZFEq67AXJUkv8zACWKyEBlCBhqICgTGm/ID2sJz05P7u4cT3iVZTfOSWwiL9sH//y/9XrgOp5bwcZ5czS3GuuRVhrq4AdcblpIn8VK0gs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754544998; c=relaxed/simple; bh=sIsFthtYJE6uf9WLr5vGByPGTS4JaFDRSkM3TlrWm+8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aY6pwcEa40uxnoFkzfYhFcgh2W6+qljlISnw6FcQH1huw6ZVUBb+MgP/SjEPRM91if1iHWo5dL5OVg7K7W21uLktxex9BIUF2Y2MG+dbKRK3v8bQVtZCvbi8d4PVcTx7q6Ce8xJHk3d25FsCnl/A28NOw4VA9yvPuVGh0+aayeA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ujtIZ-0006I9-Mn; Thu, 07 Aug 2025 07:36:19 +0200 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1ujtIX-00CKCp-3A; Thu, 07 Aug 2025 07:36:17 +0200 Received: from ore by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1ujtIX-00ECto-2i; Thu, 07 Aug 2025 07:36:17 +0200 Date: Thu, 7 Aug 2025 07:36:17 +0200 From: Oleksij Rempel To: Tristram.Ha@microchip.com Cc: Oleksij Rempel , Woojung Huh , Andrew Lunn , Vladimir Oltean , Maxime Chevallier , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , UNGLinuxDriver@microchip.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v2] net: dsa: microchip: Fix KSZ8863 reset problem Message-ID: References: <20250807005453.8306-1-Tristram.Ha@microchip.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250807005453.8306-1-Tristram.Ha@microchip.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: netdev@vger.kernel.org On Wed, Aug 06, 2025 at 05:54:53PM -0700, Tristram.Ha@microchip.com wrote: > From: Tristram Ha > > ksz8873_valid_regs[] was added for register access for KSZ8863/KSZ8873 > switches, but the reset register is not in the list so > ksz8_reset_switch() does not take any effect. > > Replace regmap_update_bits() using ksz_regmap_8 with ksz_rmw8() so that > an error message will be given if the register is not defined. > > A side effect of not resetting the switch is the static MAC table is not > cleared. Further additions to the table will show write error as there > are only 8 entries in the table. > > Fixes: d0dec3333040 ("net: dsa: microchip: Add register access control for KSZ8873 chip") > Signed-off-by: Tristram Ha Reviewed-by: Oleksij Rempel Thank you! -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |