From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Julian Anastasov <ja@ssi.bg>
Cc: Frederic Weisbecker <frederic@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Simon Horman <horms@verge.net.au>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
netdev@vger.kernel.org, lvs-devel@vger.kernel.org,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org
Subject: Re: [PATCH v2 net] ipvs: Fix estimator kthreads preferred affinity
Date: Thu, 7 Aug 2025 15:00:49 +0200 [thread overview]
Message-ID: <aJSjgW9Ln-waN_oF@calendula> (raw)
In-Reply-To: <2d915ef6-46eb-7487-f235-6b6688e68c58@ssi.bg>
On Wed, Jul 30, 2025 at 01:28:16PM +0300, Julian Anastasov wrote:
>
> Hello,
>
> On Tue, 29 Jul 2025, Frederic Weisbecker wrote:
>
> > The estimator kthreads' affinity are defined by sysctl overwritten
> > preferences and applied through a plain call to the scheduler's affinity
> > API.
> >
> > However since the introduction of managed kthreads preferred affinity,
> > such a practice shortcuts the kthreads core code which eventually
> > overwrites the target to the default unbound affinity.
> >
> > Fix this with using the appropriate kthread's API.
> >
> > Fixes: d1a89197589c ("kthread: Default affine kthread to its preferred NUMA node")
> > Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
>
> Looks good to me for the nf tree, thanks!
>
> Acked-by: Julian Anastasov <ja@ssi.bg>
For the record: Apologies, I will include this patch in the next pull request.
prev parent reply other threads:[~2025-08-07 13:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 12:26 [PATCH v2 net] ipvs: Fix estimator kthreads preferred affinity Frederic Weisbecker
2025-07-30 10:28 ` Julian Anastasov
2025-08-07 13:00 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJSjgW9Ln-waN_oF@calendula \
--to=pablo@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=frederic@kernel.org \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).