From: Joe Damato <joe@dama.to>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
willemdebruijn.kernel@gmail.com, skhawaja@google.com,
sdf@fomichev.me, shuah@kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net v2 0/3] net: prevent deadlocks and mis-configuration with per-NAPI threaded config
Date: Sat, 9 Aug 2025 18:59:27 -0700 [thread overview]
Message-ID: <aJf8_ypOuSrsQnIM@MacBook-Air.local> (raw)
In-Reply-To: <20250809001205.1147153-1-kuba@kernel.org>
On Fri, Aug 08, 2025 at 05:12:02PM -0700, Jakub Kicinski wrote:
> Running the test added with a recent fix on a driver with persistent
> NAPI config leads to a deadlock. The deadlock is fixed by patch 3,
> patch 2 is I think a more fundamental problem with the way we
> implemented the config.
>
> I hope the fix makes sense, my own thinking is definitely colored
> by my preference (IOW how the per-queue config RFC was implemented).
Maybe it's too late now, but I am open to revisiting how the whole per-queue
NAPI config works after a conversation we had a couple months ago (IIRC ?).
I think you had proposed something that made sense to me at the time (although
I can't recall what that was or what thread that was in).
next prev parent reply other threads:[~2025-08-10 1:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-09 0:12 [PATCH net v2 0/3] net: prevent deadlocks and mis-configuration with per-NAPI threaded config Jakub Kicinski
2025-08-09 0:12 ` [PATCH net v2 1/3] selftests: drv-net: don't assume device has only 2 queues Jakub Kicinski
2025-08-10 2:01 ` Joe Damato
2025-08-09 0:12 ` [PATCH net v2 2/3] net: update NAPI threaded config even for disabled NAPIs Jakub Kicinski
2025-08-10 2:04 ` Joe Damato
2025-08-09 0:12 ` [PATCH net v2 3/3] net: prevent deadlocks when enabling NAPIs with mixed kthread config Jakub Kicinski
2025-08-10 2:05 ` Joe Damato
2025-08-10 1:59 ` Joe Damato [this message]
2025-08-11 15:52 ` [PATCH net v2 0/3] net: prevent deadlocks and mis-configuration with per-NAPI threaded config Jakub Kicinski
2025-08-12 12:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJf8_ypOuSrsQnIM@MacBook-Air.local \
--to=joe@dama.to \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=skhawaja@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox