netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hangbin Liu <liuhangbin@gmail.com>
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: netdev@vger.kernel.org, Jay Vosburgh <jv@jvosburgh.net>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>,
	Jonathan Corbet <corbet@lwn.net>, Petr Machata <petrm@nvidia.com>,
	Amit Cohen <amcohen@nvidia.com>,
	Vladimir Oltean <vladimir.oltean@nxp.com>,
	Alessandro Zanni <alessandro.zanni87@gmail.com>,
	linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/3] bonding: add support for per-port LACP actor priority
Date: Tue, 12 Aug 2025 04:48:34 +0000	[thread overview]
Message-ID: <aJrHomEWwIn8a1Ql@fedora> (raw)
In-Reply-To: <a1f88a9d-14b8-4547-a6c1-b880633775a5@blackwall.org>

On Fri, Jul 25, 2025 at 11:55:54AM +0300, Nikolay Aleksandrov wrote:
> On 7/24/25 11:16, Hangbin Liu wrote:
> > Introduce a new option ad_actor_port_prio, allowing users to set the actor
> > port priority on a per-port basis in LACPDU.
> > 
> > This priority can be used in future enhancements to influence aggregator
> > selection via ad_select policy.
> > 
> > Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> > ---
> >  Documentation/networking/bonding.rst |  9 +++++++
> >  drivers/net/bonding/bond_3ad.c       |  2 ++
> >  drivers/net/bonding/bond_netlink.c   | 16 +++++++++++++
> >  drivers/net/bonding/bond_options.c   | 35 ++++++++++++++++++++++++++++
> >  include/net/bond_3ad.h               |  1 +
> >  include/net/bond_options.h           |  1 +
> >  include/uapi/linux/if_link.h         |  1 +
> >  7 files changed, 65 insertions(+)
> > 
> > diff --git a/Documentation/networking/bonding.rst b/Documentation/networking/bonding.rst
> > index a4c1291d2561..5e105e7ac8e6 100644
> > --- a/Documentation/networking/bonding.rst
> > +++ b/Documentation/networking/bonding.rst
> > @@ -193,6 +193,15 @@ ad_actor_sys_prio
> >  	This parameter has effect only in 802.3ad mode and is available through
> >  	SysFs interface.
> >  
> > +ad_actor_port_prio
> > +
> > +	In an AD system, this specifies the port priority. The allowed range
> > +	is 1 - 65535. If the value is not specified, it takes 255 as the
> 
> 
> Leaving this as a note: it is set to 255 because actor_port_priorty is initialized to 255
>                         and port_priority is initialized to actor_port_priority at slave
>                         bind time.

Hi Nikolay,

Is this a note for you? Or you want me add it to the doc?

Thanks
Hangbin

  reply	other threads:[~2025-08-12  4:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-24  8:16 [PATCH net-next 0/3] bonding: support aggregator selection based on port priority Hangbin Liu
2025-07-24  8:16 ` [PATCH net-next 1/3] bonding: add support for per-port LACP actor priority Hangbin Liu
2025-07-25  8:55   ` Nikolay Aleksandrov
2025-08-12  4:48     ` Hangbin Liu [this message]
2025-07-24  8:16 ` [PATCH net-next 2/3] bonding: support aggregator selection based on port priority Hangbin Liu
2025-07-25  9:02   ` Nikolay Aleksandrov
2025-07-25 12:48     ` Hangbin Liu
2025-07-24  8:16 ` [PATCH net-next 3/3] selftests: bonding: add test for LACP actor " Hangbin Liu
2025-07-24 14:31   ` Hangbin Liu
2025-07-24 14:35     ` Jakub Kicinski
2025-07-25  2:20       ` Hangbin Liu
2025-07-25 14:27         ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aJrHomEWwIn8a1Ql@fedora \
    --to=liuhangbin@gmail.com \
    --cc=alessandro.zanni87@gmail.com \
    --cc=amcohen@nvidia.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jv@jvosburgh.net \
    --cc=kuba@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=petrm@nvidia.com \
    --cc=razor@blackwall.org \
    --cc=shuah@kernel.org \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).