From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B1C42D0624 for ; Tue, 12 Aug 2025 20:57:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755032282; cv=none; b=Y1z8rwnMRe8xB41FU16NMeF4SzoPZW6fjKlc3BJvA8H1drxtyU+t9oA1/qwZZVl6eB1dwZcWln5PHwp22mbt6kjSx67o6MK44vDXSAx6x+HL9YeAe4zzgE+7gueiwYl3yzoLvwrdtiXScTW5/26Q15mbQRnQcBvfZxDcYNYKCDA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755032282; c=relaxed/simple; bh=6Q4Oq/xbYw0awazOURcsOPsRowz4FU6cz3+FWT4ucTE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MEc2TWXanF8cgsTn2Idte44viTHU3uDvYRAFg1RBKnzwTO67K5NzQMMxNvOSekNIGuF0aAXD8gmlKG90lRA2fTI1w6WFxG4pF+MFVvqBFH7DmYGjlnmDorg6pWEoeTV2SrueLDQfdPOXSFGB0h2yLA8zjXrlw6g6v6v+LuCzZHo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=j-ernberg.se; spf=none smtp.mailfrom=j-ernberg.se; dkim=pass (2048-bit key) header.d=j-ernberg-se.20230601.gappssmtp.com header.i=@j-ernberg-se.20230601.gappssmtp.com header.b=XmX097A4; arc=none smtp.client-ip=209.85.167.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=j-ernberg.se Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=j-ernberg.se Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=j-ernberg-se.20230601.gappssmtp.com header.i=@j-ernberg-se.20230601.gappssmtp.com header.b="XmX097A4" Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-55b88369530so6297063e87.0 for ; Tue, 12 Aug 2025 13:57:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=j-ernberg-se.20230601.gappssmtp.com; s=20230601; t=1755032277; x=1755637077; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=I1HYkWTm//0TzFaX3HirV9CEefr3/XfGLtwUTGZHPfw=; b=XmX097A4d4aVc/Gm/pMW5w7QcjfhJBwgREdg5Ti/XzhesoiDcPOgUqMyo1c5m/21Mf rP2g7nDZt1SaXpStcfjFV49zpLaBGIxXV4b3Ag6tueKayOSo/ye5ODThF8WWauv69MhY FpdcZpLez17cagD3kwFo77yFfwBmHlSKRWduqXGf2QdguEVGZjZ2/ZJ0vFNrVsUmZN38 Cj04P64hya7wsM3VQHzetfGfumlQ9CvVvkqQJZJ4bsTC3kfcaxY1JzPrUYx1cfWPaFxW 1wM+PuLZEvV0pDsJnt+GX587fxcOtks42wqnE4JkM2zFQCEgM5kpZk/8BNzG06nsBLpY Cb8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755032277; x=1755637077; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=I1HYkWTm//0TzFaX3HirV9CEefr3/XfGLtwUTGZHPfw=; b=ROKZxREwVLz2aQ49JiWCF0dJdKYwncHxJzfrsj22G0vtxUh0XdBQ0uC2OMlkoooCCM dkrbWQL5bdhO+dHSngGCCN5X3jVwYyuO4h8AF4q/ir+27oj614xiqHPGK17IG3kMOwkb N6TatqfaOW3yhaejE+3Z7NDm/SFdxwvExs6+Vvb1agqOhD2B8yVwmdQzb6Eij0isi54I 5V4o56M2NAVuhPhIXjr/uqIU4q+J4sjJTnh45C6R4UAc3i6yXQNTEDdqbo8RQfk0D2ET c2VSq3hOkRFw1ZxZ6k0Dsvc3ch66IpsEFNBlA2276VsOVnTRo7zPBouaYrTpAJvTMZFn xY4g== X-Forwarded-Encrypted: i=1; AJvYcCUG1cNcWtW5sck9b1YrIileiHi8DTbakcHKrzF0yJr+x0ROBRaWiPpF18xTs/F/CscAXKB7OFM=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6MwHwVaG1hiG+9ErjPSJUePcWpCnO64/ffCfmJoGHdAHhb2qL cFf/rwLfsUeemM0HbjIbdc1j2hc6fes6Jj+ByNbigukWYLCsth2IcVhXGChnhATtdcA= X-Gm-Gg: ASbGncvCscEiJy/aWyCC8ZtIhv1tKuV6puPbvICa7INh4TyjVV2VDXwbxCMzlIH1ohr /MhLdeFoM2mPX75eYYs7nZJnjVG9nKwFC1Mye1/itHbPffvX39HFWWqwcMg16gCb4I7MU9kIdED FU103/j2Qa3X7ibRUlSPGG4YYz5+L+nyxE4wbnQqxBM7GxUmiI3uYG2kVIC6BohqonXoAzv83nJ gyr2w88oBoyBrz9nzLFxtrr5Kw1j3t0MlJtsbi+jo30z13rcErg6Qz/w2W7Z3VQkLrZGLIkmKv6 f6fl5uBjkYy/vOeuLlzu1BxR8+BjB7nOgNczs9nAOdovj0nlZFAwx25ujodbL73mvMFUl5Qutrq aoruASlu207OTuPkoNm6zzPFswaWx85HN5MzprvBcswH3isZorw== X-Google-Smtp-Source: AGHT+IGffUI/1EXOSK/t0KV6xGplfLMgAAk2k7PICLXaMIAixPTAVPj1NMw1SVef+Ih1sVF86CbZxw== X-Received: by 2002:a05:6512:b12:b0:55a:4f05:6e4c with SMTP id 2adb3069b0e04-55ce0404609mr162441e87.49.1755032276914; Tue, 12 Aug 2025 13:57:56 -0700 (PDT) Received: from localhost (90-231-233-65-no2360.tbcn.telia.com. [90.231.233.65]) by smtp.gmail.com with UTF8SMTPSA id 2adb3069b0e04-55b88c990f1sm4946123e87.82.2025.08.12.13.57.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Aug 2025 13:57:56 -0700 (PDT) Date: Tue, 12 Aug 2025 22:57:55 +0200 From: John Ernberg To: Jakub Kicinski , Linus Torvalds , Ammar Faizi Cc: Simon Horman , Oliver Neukum , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Greg Kroah-Hartman , Linux Netdev Mailing List , Linux USB Mailing List , Linux Kernel Mailing List , Armando Budianto , gwml@vger.gnuweeb.org, stable@vger.kernel.org, John Ernberg Subject: Re: [PATCH net v2] net: usbnet: Fix the wrong netif_carrier_on() call placement Message-ID: References: <20250801190310.58443-1-ammarfaizi2@gnuweeb.org> <20250804100050.GQ8494@horms.kernel.org> <20250805202848.GC61519@horms.kernel.org> <20250805164747.40e63f6d@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250805164747.40e63f6d@kernel.org> Hi Jakub, Linus, Ammar, (sorry for the delay, on vacation, wasn't paying attention to the internet) On Tue, Aug 05, 2025 at 04:47:47PM -0700, Jakub Kicinski wrote: > On Wed, 6 Aug 2025 01:40:37 +0300 Linus Torvalds wrote: > > So my gut feel is that the > > > > if (test_and_clear_bit(EVENT_LINK_CARRIER_ON, &dev->flags)) > > netif_carrier_on(dev->net); > > > > should actually be done outside that if-statement entirely, because it > > literally ends up changing the thing that if-statement is testing. > > Right. I think it should be before the if (!netif_carrier_ok(dev->net)) > > Ammar, could you retest and repost that, since we haven't heard from > John? I can't verify the suggested change until sometime in September, after I return to office, but it feels correct. However... I'm almost inclined to suggest a full revert of my patch as the testing was clearly royally botched. Booting it on the boards I have would have shown the failure immediately. (I did see v3 of this patch being applied) Apologies for the mess // John Ernberg