* [PATCH v2] net: stmmac: add support for dwmac 5.20
@ 2025-07-05 9:09 Jisheng Zhang
2025-07-05 15:51 ` Andrew Lunn
0 siblings, 1 reply; 4+ messages in thread
From: Jisheng Zhang @ 2025-07-05 9:09 UTC (permalink / raw)
To: Andrew Lunn, David S . Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Maxime Coquelin, Alexandre Torgue
Cc: netdev, linux-arm-kernel, linux-kernel
The dwmac 5.20 IP can be found on some synaptics SoCs. Add a
compatibility flag for it.
Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
---
Since v1:
- fix the commit msg
drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c
index b9218c07eb6b..cecce6ed9aa6 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c
@@ -59,6 +59,7 @@ static const struct of_device_id dwmac_generic_match[] = {
{ .compatible = "snps,dwmac-3.72a"},
{ .compatible = "snps,dwmac-4.00"},
{ .compatible = "snps,dwmac-4.10a"},
+ { .compatible = "snps,dwmac-5.20"},
{ .compatible = "snps,dwmac"},
{ .compatible = "snps,dwxgmac-2.10"},
{ .compatible = "snps,dwxgmac"},
--
2.49.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] net: stmmac: add support for dwmac 5.20
2025-07-05 9:09 [PATCH v2] net: stmmac: add support for dwmac 5.20 Jisheng Zhang
@ 2025-07-05 15:51 ` Andrew Lunn
2025-07-05 19:05 ` Russell King (Oracle)
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Lunn @ 2025-07-05 15:51 UTC (permalink / raw)
To: Jisheng Zhang
Cc: Andrew Lunn, David S . Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Maxime Coquelin, Alexandre Torgue, netdev,
linux-arm-kernel, linux-kernel
On Sat, Jul 05, 2025 at 05:09:30PM +0800, Jisheng Zhang wrote:
> The dwmac 5.20 IP can be found on some synaptics SoCs. Add a
> compatibility flag for it.
Is a compatible flag enough to make it actually work?
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] net: stmmac: add support for dwmac 5.20
2025-07-05 15:51 ` Andrew Lunn
@ 2025-07-05 19:05 ` Russell King (Oracle)
2025-08-13 0:31 ` Jisheng Zhang
0 siblings, 1 reply; 4+ messages in thread
From: Russell King (Oracle) @ 2025-07-05 19:05 UTC (permalink / raw)
To: Andrew Lunn
Cc: Jisheng Zhang, Andrew Lunn, David S . Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Maxime Coquelin, Alexandre Torgue,
netdev, linux-arm-kernel, linux-kernel
On Sat, Jul 05, 2025 at 05:51:11PM +0200, Andrew Lunn wrote:
> On Sat, Jul 05, 2025 at 05:09:30PM +0800, Jisheng Zhang wrote:
> > The dwmac 5.20 IP can be found on some synaptics SoCs. Add a
> > compatibility flag for it.
>
> Is a compatible flag enough to make it actually work?
Also, shouldn't there be a binding doc update?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] net: stmmac: add support for dwmac 5.20
2025-07-05 19:05 ` Russell King (Oracle)
@ 2025-08-13 0:31 ` Jisheng Zhang
0 siblings, 0 replies; 4+ messages in thread
From: Jisheng Zhang @ 2025-08-13 0:31 UTC (permalink / raw)
To: Russell King (Oracle)
Cc: Andrew Lunn, Andrew Lunn, David S . Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Maxime Coquelin, Alexandre Torgue,
netdev, linux-arm-kernel, linux-kernel
On Sat, Jul 05, 2025 at 08:05:50PM +0100, Russell King (Oracle) wrote:
> On Sat, Jul 05, 2025 at 05:51:11PM +0200, Andrew Lunn wrote:
> > On Sat, Jul 05, 2025 at 05:09:30PM +0800, Jisheng Zhang wrote:
> > > The dwmac 5.20 IP can be found on some synaptics SoCs. Add a
> > > compatibility flag for it.
> >
> > Is a compatible flag enough to make it actually work?
Yep, it's enough, we are using dwmac-generic.c for DT based platforms
>
> Also, shouldn't there be a binding doc update?
The binding doc is already upstreamed by the following commit:
13f9351180aa ("dt-bindings: net: snps,dwmac: Add dwmac-5.20 version")
Hi Russell, Andrew,
Kindly let me know if I still need to do more to let this CL merged.
Thanks in advance
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-08-13 0:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-05 9:09 [PATCH v2] net: stmmac: add support for dwmac 5.20 Jisheng Zhang
2025-07-05 15:51 ` Andrew Lunn
2025-07-05 19:05 ` Russell King (Oracle)
2025-08-13 0:31 ` Jisheng Zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).