From: Florian Westphal <fw@strlen.de>
To: qianjiaru77@gmail.com
Cc: steffen.klassert@secunet.com, herbert@gondor.apana.org.au,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] Reference Counting Vulnerability in Linux XFRM PolicyManagement
Date: Tue, 26 Aug 2025 18:49:06 +0200 [thread overview]
Message-ID: <aK3lUhooKnI3gMmW@strlen.de> (raw)
In-Reply-To: <20250826162500.34292-1-qianjiaru77@gmail.com>
qianjiaru77@gmail.com <qianjiaru77@gmail.com> wrote:
> diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c
> index c5035a9bc..50943fa4e 100644
> --- a/net/xfrm/xfrm_policy.c
> +++ b/net/xfrm/xfrm_policy.c
> @@ -3786,6 +3786,7 @@ int __xfrm_policy_check(struct sock *sk, int dir, struct sk_buff *skb,
> if (IS_ERR(pols[1])) {
> XFRM_INC_STATS(net, LINUX_MIB_XFRMINPOLERROR);
> xfrm_pol_put(pols[0]);
> + pols[0] = NULL; // Clear pointer to prevent reuse
> return 0;
> }
This change makes no sense to me. pols[] has automatic storage duration;
its existence isn't visible to the callers of __xfrm_policy_check().
Is this report generated by some tool?
If that tool is syzkaller, please share the full backtrace.
prev parent reply other threads:[~2025-08-26 16:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-26 16:25 [PATCH 1/1] Reference Counting Vulnerability in Linux XFRM PolicyManagement qianjiaru77
2025-08-26 16:49 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aK3lUhooKnI3gMmW@strlen.de \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=qianjiaru77@gmail.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox