From: Guillaume Nault <gnault@redhat.com>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
James Chapman <jchapman@katalix.com>
Subject: Re: [PATCH net] l2tp: do not use sock_hold() in pppol2tp_session_get_sock()
Date: Wed, 27 Aug 2025 14:05:34 +0200 [thread overview]
Message-ID: <aK70jgXUtSHIdrOW@debian> (raw)
In-Reply-To: <20250826134435.1683435-1-edumazet@google.com>
On Tue, Aug 26, 2025 at 01:44:35PM +0000, Eric Dumazet wrote:
> pppol2tp_session_get_sock() is using RCU, it must be ready
> for sk_refcnt being zero.
>
> Commit ee40fb2e1eb5 ("l2tp: protect sock pointer of
> struct pppol2tp_session with RCU") was correct because it
> had a call_rcu(..., pppol2tp_put_sk) which was later removed in blamed commit.
Reviewed-by: Guillaume Nault <gnault@redhat.com>
Thank!
next prev parent reply other threads:[~2025-08-27 12:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-26 13:44 [PATCH net] l2tp: do not use sock_hold() in pppol2tp_session_get_sock() Eric Dumazet
2025-08-27 12:05 ` Guillaume Nault [this message]
2025-08-28 0:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aK70jgXUtSHIdrOW@debian \
--to=gnault@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=jchapman@katalix.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox